Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

feat(lyra-newport): Add Lyra Network Integration #2316

Merged
merged 5 commits into from
Feb 16, 2023

Conversation

paulvaden
Copy link
Contributor

@paulvaden paulvaden commented Feb 16, 2023

Description

Add Lyra newport release

Checklist

  • [ x] I have followed the Contributing Guidelines
  • (optional) As a contributor, my Ethereum address/ENS is:
  • (optional) As a contributor, my Twitter handle is:

How to test?

0xa5a663b7951dddff89b01194ee16f3af276051c1
0x81ad5e6fa4c085b78ed547125170823e6d2b2478
0x80ece3be489daafb1bc33b1632c03d918c00b32d

@wpoulin
Copy link
Contributor

wpoulin commented Feb 16, 2023

Updating your last commit message and PR title to something like feat(lyra-newport): Add Lyra Network Integration will resolve the issue

@paulvaden paulvaden changed the title Lyra newport changes feat(lyra-newport): Add Lyra Network Integration Feb 16, 2023
@wpoulin wpoulin merged commit 7b0aace into Zapper-fi:main Feb 16, 2023
@SamIam-0x
Copy link
Contributor

hey thanks for adding this @paulvaden !

Smol request after QA'ing - can we update the app slug label from lyra-newport to Lyra Newport? Thanks!

@paulvaden
Copy link
Contributor Author

hey thanks for adding this @paulvaden !

Smol request after QA'ing - can we update the app slug label from lyra-newport to Lyra Newport? Thanks!

How is that done?

@SamIam-0x
Copy link
Contributor

SamIam-0x commented Feb 23, 2023 via email

0xdapper pushed a commit to 0xdapper/studio that referenced this pull request Feb 28, 2023
* feat(lyra-newport): Add Lyra Network Integration

---------

Co-authored-by: William Poulin <[email protected]>
@SamIam-0x
Copy link
Contributor

Hello @paulvaden - thanks for submitting this!

qq- do you have an ENS or address you'd want us to attribute this contribution to? We are building out a leaderboard to give credit to users who contributed to Zapper, with potential bonus points of value in the future.

Let me know, thanks!
Sam

@paulvaden
Copy link
Contributor Author

@SamIam-0x Yup you can use muir-lyra.eth, thanks!

@SamIam-0x
Copy link
Contributor

SamIam-0x commented Nov 1, 2023 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants