This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello @tonzgao ! Noticed a few things:
|
Few more small things but I think we’re really close to being done now! |
If possible, please split the group to “v3Pool” and “v3Farm” as well (this enables us to do TVL calculation in the future very easily) |
Sorry I just realized I didn’t submit a few comments 😅 |
This was referenced May 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add bancorv3
fyi not a dev for this project
Checklist
How to test?
contract and deposits found here https://etherscan.io/address/0xb0B958398ABB0b5DB4ce4d7598Fb868f5A00f372
docs: https://docs.bancor.network/developer-guides/read-functions/rewards