Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

feat: add bancorv3 #437

Merged
merged 7 commits into from
May 16, 2022
Merged

feat: add bancorv3 #437

merged 7 commits into from
May 16, 2022

Conversation

tonzgao
Copy link
Contributor

@tonzgao tonzgao commented May 14, 2022

Description

add bancorv3

fyi not a dev for this project

Checklist

  • I have followed the Contributing Guidelines
  • (optional) As a contributor, my Ethereum address/ENS is: what is this for, is it for tips or airdrops or something?

How to test?

contract and deposits found here https://etherscan.io/address/0xb0B958398ABB0b5DB4ce4d7598Fb868f5A00f372
docs: https://docs.bancor.network/developer-guides/read-functions/rewards

@immasandwich
Copy link
Contributor

Hello @tonzgao ! Noticed a few things:

  1. We should have a bancor.pool.token-fetcher.ts to represent the pool token deposits (like bnBNT, bnDAI, etc). The pricrPerShare for these tokens can be derived from https://etherscan.io/address/0xec9596e0eb67228d61a12cfdb4b3608281f261b3#readContract

  2. Then, you’ll see that the deposits to the StandardRewards contracts are actually these tokens (i.e: the user has a bnDAI deposit in the StandardRewards contract)

@immasandwich
Copy link
Contributor

Few more small things but I think we’re really close to being done now!

@immasandwich
Copy link
Contributor

If possible, please split the group to “v3Pool” and “v3Farm” as well (this enables us to do TVL calculation in the future very easily)

@immasandwich
Copy link
Contributor

Sorry I just realized I didn’t submit a few comments 😅

@tonzgao tonzgao requested a review from immasandwich May 16, 2022 13:01
@immasandwich immasandwich merged commit 058a733 into Zapper-fi:main May 16, 2022
This was referenced May 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants