Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

feat(solace): integrate solace finance #457

Merged
merged 4 commits into from
May 20, 2022

Conversation

leonardishere
Copy link
Contributor

Description

Integrate Solace Finance https://solace.fi

Checklist

  • I have followed the Contributing Guidelines
  • (optional) As a contributor, my Ethereum address/ENS is: dirtydrew.eth

How to test?

http://localhost:5001/apps/solace/tokens?groupIds[]=scp&network=ethereum
http://localhost:5001/apps/solace/balances?addresses[]=0xdd6fd6622d4af631d8c5c1f637526e89ccff9646&network=ethereum

http://localhost:5001/apps/solace/tokens?groupIds[]=xsolacev1&network=ethereum
http://localhost:5001/apps/solace/balances?addresses[]=0xdcccb0d14ce364e901efb339db74daa4e355845b&network=ethereum

http://localhost:5001/apps/solace/positions?groupIds[]=bonds&network=ethereum
no active holders

http://localhost:5001/apps/solace/positions?groupIds[]=xslocker&network=ethereum
http://localhost:5001/apps/solace/balances?addresses[]=0xa15d8c59241e2bf2f635701e695a5c60dfaa45e7&network=ethereum

http://localhost:5001/apps/solace/positions?groupIds[]=policies&network=ethereum
http://localhost:5001/apps/solace/balances?addresses[]=0x9a1768f92c57e7b0f609364185c92404049f4f3b&network=ethereum

http://localhost:5001/apps/solace/positions?groupIds[]=bonds&network=polygon
http://localhost:5001/apps/solace/balances?addresses[]=0x956ce2e14a976640c7c42e2825cd4e5d733f27b5&network=polygon

http://localhost:5001/apps/solace/positions?groupIds[]=xslocker&network=polygon
http://localhost:5001/apps/solace/balances?addresses[]=0x606e8cd25d7994db3c869a271f7143c68fb9ce88&network=polygon

http://localhost:5001/apps/solace/positions?groupIds[]=policies&network=polygon
http://localhost:5001/apps/solace/balances?addresses[]=0x853c73d583abbe672fde8da0ffc0a2ae4a01a8ce&network=polygon

http://localhost:5001/apps/solace/tvl?network=ethereum
http://localhost:5001/apps/solace/tvl?network=polygon

@wpoulin
Copy link
Contributor

wpoulin commented May 19, 2022

Hi,

Good job on the implementation 💪

Overall comment, I strongly suggest you would use the "real" variable's type instead of using any because it kinda defeats the purpose and pros of using Typescript. Here's an example,

`export default async function getBondBalance(
  address: string, 
  appToolkit: any, 
  solaceContractFactory: SolaceContractFactory
) {`

instead of any, you could use the appToolkit interface IAppToolkit

`export default async function getBondBalance(
  address: string, 
  appToolkit: IAppToolkit, 
  solaceContractFactory: SolaceContractFactory
) {`

@leonardishere
Copy link
Contributor Author

leonardishere commented May 19, 2022

I strongly suggest you would use the "real" variable's type instead of using any because it kinda defeats the purpose and pros of using Typescript.

Fair point. fixed

@immasandwich immasandwich merged commit 860de45 into Zapper-fi:main May 20, 2022
dominikpre pushed a commit to EaseDeFi/ease-zapper-integration that referenced this pull request May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants