This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
fix(curve): Use virtual price in v2 Pools price calculation #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
immasandwich
approved these changes
Jun 7, 2022
pwele
force-pushed
the
fix-curve-pool-price
branch
from
51c989f to
45ff191
Compare
pwele
force-pushed
the
fix-curve-pool-price
branch
from
45ff191 to
bd64eb3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for this issue. For TriCrypto2 and other v2 Pools, we are using a liquidity based price calculation (
liquidity / supply). The pool virtual price ignored. The right calculation should bevirtual price * LP token price.Checklist
How to test?
http://localhost:5001/apps/curve/tokens?groupIds%5B%5D=pool&network=ethereum