Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Signing #249

Closed
wants to merge 4 commits into from
Closed

AWS Signing #249

wants to merge 4 commits into from

Conversation

radar
Copy link

@radar radar commented Oct 5, 2016

Hello!

I've come across a usecase where I want to use this package with an AWS Elasticsearch instance, and I also want to have requests signed because the documents are sensitive. I noticed that your package didn't support this yet, so I've worked on a patch to make it do that.

To make it work with AWS, I've added the ability to configure it like this:

config :tirexs,
  uri: "uri",
  aws_elasticsearch: true,
  aws_access_key_id: "key",
  aws_secret_access_key: "secret",
  aws_region: "region"

If the aws_elasticsearch option is set to true, then this patch uses the aws_auth package to add Amazon's signature details to the URL. If it's not set, then this package continues on as it always has.

[ {:exjsx, "~> 3.2.0"}, {:ex_doc, "~> 0.12", only: :dev}, {:earmark, "~> 1.0", only: :dev} ]
[
{:exjsx, "~> 3.2.0"},
{:aws_auth, "~> 0.5.1"},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this lib must be maybe at dev, if i don't use AWS, why this lib comes and compiles? i can add it manual, so include it just for dev and test

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed

@Zatvobor
Copy link
Owner

I don't like it. It should be moved away fromTirexs.HTTP into context specific module.

@radar radar closed this Oct 19, 2016
@radar
Copy link
Author

radar commented Oct 19, 2016

Thanks for your consideration. Going to use my own library.

@Zatvobor
Copy link
Owner

Awesome.

@matrinox matrinox mentioned this pull request Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants