Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I've come across a usecase where I want to use this package with an AWS Elasticsearch instance, and I also want to have requests signed because the documents are sensitive. I noticed that your package didn't support this yet, so I've worked on a patch to make it do that.
To make it work with AWS, I've added the ability to configure it like this:
If the
aws_elasticsearch
option is set totrue
, then this patch uses theaws_auth
package to add Amazon's signature details to the URL. If it's not set, then this package continues on as it always has.