Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse inv messages. #24

Closed
hdevalence opened this issue Sep 24, 2019 · 4 comments
Closed

Parse inv messages. #24

hdevalence opened this issue Sep 24, 2019 · 4 comments
Assignees

Comments

@hdevalence
Copy link
Contributor

We should be able to parse inventory messages.

@hdevalence hdevalence self-assigned this Sep 25, 2019
@hdevalence
Copy link
Contributor Author

I think this is blocked on #21, because in order to represent the "inventory items" as

/// An inventory item which refers to some advertised or requested data.
#[derive(Copy, Clone, Debug, Eq, PartialEq)]
enum InventoryItem {
    Error,
    Tx(TxHash),
    Block(BlockHash),
    FilteredBlock(BlockHash),
}

we need the TxHash, BlockHash types to exist already.

@hdevalence
Copy link
Contributor Author

@dconnolly can I move the existing InventoryType/InventoryVector structs out of zebra-chain and into zebra-network? I think that they're just used for the network protocol, so it seems like a better home.

@dconnolly
Copy link
Contributor

@dconnolly can I move the existing InventoryType/InventoryVector structs out of zebra-chain and into zebra-network? I think that they're just used for the network protocol, so it seems like a better home.

Yes I think this is correct, Inventory* look like message or general metadata rather than an independent type. 👍

@hdevalence
Copy link
Contributor Author

Closed by the combination of #31 and #38 (which replaced some stub types).

skyl added a commit to skyl/zebra that referenced this issue Sep 25, 2024
## What

Donate 2Z or ZEC from creator page

## Why

Start to make 2Z more useful, make creator page better, have place for
actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants