Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an Abscissa command for DNS seeder information. #54

Closed
hdevalence opened this issue Oct 7, 2019 · 5 comments
Closed

Add an Abscissa command for DNS seeder information. #54

hdevalence opened this issue Oct 7, 2019 · 5 comments
Assignees

Comments

@hdevalence
Copy link
Contributor

Our MVP to test our new networking design is a daemon that can power a DNS seeder; this is a trivial application but it is measurable and concrete and tests that the networking design does actually work in a visible way, before we complete the rest of the work of the node implementation.

Currently the only command we have is the connect command, which exists solely for debugging during development and is intended to be thrown away.

To run the daemon we need to have a different command. This could either be called run (the future command to start a full node should certainly be run), or something else to indicate that the command only does address spidering and that the rest of the node functionality is not yet implemented. Thoughts?

@hdevalence
Copy link
Contributor Author

(Tagged later because this depends on at least #53 #52 #51 #50 #49 #48 #47 #46 #45 #26 #18 and probably others)

@dconnolly
Copy link
Contributor

dconnolly commented Oct 21, 2019

Call network.init(), handle GetPeers requests, and keep updating our AddressBook of our crawled data.

@hdevalence
Copy link
Contributor Author

As part of this, we can probably remove the connect stub, since it won't be needed any more.

dconnolly added a commit that referenced this issue Nov 7, 2019
Moved SeedService out of the command closure Command currently spawns
a tokio task to DOS the seed service with `Request::GetPeers` every
second.

Pertains to #54
dconnolly added a commit that referenced this issue Nov 13, 2019
Moved SeedService out of the command closure Command currently spawns
a tokio task to DOS the seed service with `Request::GetPeers` every
second.

Pertains to #54
@dconnolly
Copy link
Contributor

As part of this, we can probably remove the connect stub, since it won't be needed any more.

I've been modifying the connect command frequently in local testing so not removing as part of completion of this issue yet.

@dconnolly
Copy link
Contributor

Resolved by #54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants