Use max_items as bound in tower-batch #1691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://github.com/tower-rs/tower/blob/master/tower/src/semaphore.rs#L93-L100 If so, we might have to use an older version:
We changed the approach on how to do this, this comment do not apply anymore. |
oxarbitrage
force-pushed
the
issue1670
branch
from
ba63e1a to
bf42e46
Compare
oxarbitrage
changed the title
bound from tower-buffer into Zebra tower-batch
oxarbitrage
commented
Feb 4, 2021
teor2345
reviewed
Feb 4, 2021
Co-authored-by: teor <[email protected]>
teor2345
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to change the max number of requests of the semaphore in zebra-batch.
Closes #1670
Solution
I discussed with @teor2345 that the best by now for this will be to use
max_itemsargument asbound.Review
@teor2345