Kill running acceptance test nodes on error, and show their output #1770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And show the output from those nodes. These changes help us diagnose errors that happen while one or more acceptance test nodes are running.
teor2345
added
A-rust
oxarbitrage
approved these changes
Feb 18, 2021
|
The test failure is Testnet, which will be fixed by #1222 |
This was referenced Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When our CI fails some acceptance tests, we don't get enough output to diagnose the error.
Solution
These changes help us diagnose errors that happen while one or more acceptance test nodes are running.
The code in this pull request has:
Review
This is pretty important, because it helps diagnose bugs like #1765 and #1769.
Related Issues
Diagnostics for #1765
Diagnostics for #1769
#1766 provides diagnostics in
zebradcode, this PR prints them when the test errors.Follow Up Work
Actually fix the bugs causing the CI failures.