Pass the finalized state to chain contextual validation #2503
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To check for missing UTXOs, we need to have the block, non-finalized chain, and finalized chain UTXOs.
The only place we have all the right data is just before we commit a block to a non-finalized chain.
So we need to pass the finalized state to this method.
Solution
This PR is part of #2231, but it doesn't close that ticket.
Review
This change will impact work that @conradoplg and @oxarbitrage are doing right now, so they should both review it.
We should try to get it merged soon, so we can avoid conflicts with that work.
Reviewer Checklist
This code has existing tests, and the finalized state will be tested as part of the transparent double spend checks in #2231.