Fix test failures by flushing output streams before exiting Zebra #2911

teor2345 · 2021-10-20T04:47:07Z

Motivation

I think that macOS might be dropping log output when the process exits, so our tests fail.
I've seen similar test errors on macOS before.

This is unexpected work in sprint 21.

Solution

flush stdout and stderr streams before exiting Zebra

Review

Anyone can review.

This is urgent, because CI is still failing.

Reviewer Checklist

Existing tests pass on all platforms

Next Steps

Try sending an empty line before the flush
Disable these tests on macOS CI

dconnolly · 2021-10-20T22:08:30Z

zebra-state/src/service/finalized_state.rs

+        // Some OSes require a flush to send all output to the terminal.
+        // Zebra's logging doesn't depend on `tokio`, so we flush the stdlib sync streams.


dconnolly · 2021-10-20T22:09:01Z

zebrad/src/application.rs

+        let _ = stdout().lock().flush();
+        let _ = stderr().lock().flush();


Try flushing streams before exiting Zebra

dd761ef

teor2345 added C-bug Category: This is a bug P-High I-integration-fail Continuous integration fails, including build and test failures labels Oct 20, 2021

teor2345 added this to the 2021 Sprint 21 milestone Oct 20, 2021

teor2345 requested a review from a team October 20, 2021 04:47

teor2345 self-assigned this Oct 20, 2021

teor2345 changed the title ~~Try flushing streams before exiting Zebra~~ Flush streams before exiting Zebra to fix test failures Oct 20, 2021

teor2345 changed the title ~~Flush streams before exiting Zebra to fix test failures~~ Fix test failures by flushing output streams before exiting Zebra Oct 20, 2021

teor2345 enabled auto-merge (squash) October 20, 2021 04:58

conradoplg approved these changes Oct 20, 2021

View reviewed changes

teor2345 merged commit e277975 into main Oct 20, 2021

teor2345 deleted the flush-stdout branch October 20, 2021 13:57

dconnolly reviewed Oct 20, 2021

View reviewed changes

teor2345 mentioned this pull request Oct 21, 2021

In tests, keep reading buffered child process output even after it has exited #2923

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix test failures by flushing output streams before exiting Zebra #2911

Fix test failures by flushing output streams before exiting Zebra #2911

teor2345 commented Oct 20, 2021 •

edited

Loading

dconnolly Oct 20, 2021

dconnolly Oct 20, 2021

		// Some OSes require a flush to send all output to the terminal.
		// Zebra's logging doesn't depend on `tokio`, so we flush the stdlib sync streams.

		let _ = stdout().lock().flush();
		let _ = stderr().lock().flush();

Fix test failures by flushing output streams before exiting Zebra #2911

Fix test failures by flushing output streams before exiting Zebra #2911

Conversation

teor2345 commented Oct 20, 2021 • edited Loading

Motivation

Solution

Review

Reviewer Checklist

Next Steps

dconnolly Oct 20, 2021

Choose a reason for hiding this comment

dconnolly Oct 20, 2021

Choose a reason for hiding this comment

teor2345 commented Oct 20, 2021 •

edited

Loading