T1. Fix isolated connection bugs, improve tests, upgrade dependencies

[teor2345]

Motivation

This PR contains some zebra-network changes that are required or useful for Tor support using arti. But it doesn't add any arti dependencies or Tor code yet. (That's in the next PR.)

We should merge this PR because these are all improvements, and we will have to do them eventually anyway.

It also makes testing easier, because it lets us write tests that don't depend on the network. And it improves test coverage.

Solution

Enhancements:

• Make handshakes generic over AsyncRead + AsyncWrite
• Add a wrapper function for isolated TCP connections to an IP address

Dependencies:

• Upgrade Zebra dependencies to be compatible with arti, but don't add any Tor dependencies yet
  • This just happens to close Remove outdated http dependencies #2999

Fixes & Cleanups:

• Simplify connect_isolated using ServiceExt::map_err and BoxError
• Support connect_isolated on testnet, closes connect_isolated only works on mainnet #1687
• Move isolated network tests to their own module

Testing:

• Improve isolated TCP connection tests
• Add an in-memory connection test that uses AsyncReadWrite

Review

This PR is ready for review, @dconnolly can review it.

It might have merge conflicts with future PRs, so we should get it in soon.

Reviewer Checklist

• Code implements Specs and Designs
• Tests for Expected Behaviour
• Tests for Errors

Follow Up Work

Actually add Tor support.

[codecov]

Codecov Report

Merging #3302 (29a8c62) into main (ee9f081) will increase coverage by 0.00%.
The diff coverage is 60.81%.

@@           Coverage Diff           @@
##             main    #3302   +/-   ##
=======================================
  Coverage   77.79%   77.80%           
=======================================
  Files         266      266           
  Lines       31449    31449           
=======================================
+ Hits        24466    24469    +3     
+ Misses       6983     6980    -3     

[conradoplg]

I've synced with main and solved conflicts

[conradoplg]

Looks good!