Document consensus rules from 7.3 Spend Description Encoding and Consensus #3575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conradoplg
commented
Feb 17, 2022
conradoplg
commented
Feb 17, 2022
Codecov Report
@@ Coverage Diff @@
## main #3575 +/- ##
==========================================
+ Coverage 78.34% 80.15% +1.81%
==========================================
Files 267 276 +9
Lines 31526 32371 +845
==========================================
+ Hits 24698 25947 +1249
+ Misses 6828 6424 -404 |
dconnolly
force-pushed
the
document-consensus-7.3-spend
branch
from
b42dc38 to
8d1aca3
Compare
dconnolly
approved these changes
Feb 18, 2022
This was referenced Feb 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We must document and double-check all consensus rules
Specifications
Designs
Solution
This also removes some duplicated comments that somehow ended up appearing (I think by some automatic merge)
Closes #3224
Review
@dconnolly and/or @upbqdn might want to review
Reviewer Checklist
Follow Up Work