Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(release): Only allow releases from the main branch, and update workflow names #7917

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Nov 7, 2023

Motivation

  1. We could accidentally release from any branch, but we only want to release from main
  2. Some of the workflow names have changed, so they need to be updated in the release template

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users? Internal PR
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?

Not a significant change.

If a checkbox isn't relevant to the PR, mark it as done.

Specifications

https://github.com/crate-ci/cargo-release/blob/master/docs/reference.md#config-fields

Solution

  1. Configure cargo release to only release from main (it exits with an error for any other branch)
  2. Update workflow links

Testing

I manually tested releasing from another branch fails, and I tested the links.

Review

This is a low priority cleanup.

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

@teor2345 teor2345 added C-cleanup Category: This is a cleanup P-Low ❄️ C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG A-release Area: Zebra releases and release management labels Nov 7, 2023
@teor2345 teor2345 self-assigned this Nov 7, 2023
@teor2345 teor2345 requested a review from a team as a code owner November 7, 2023 01:49
@teor2345 teor2345 requested review from upbqdn and removed request for a team November 7, 2023 01:49
mergify bot added a commit that referenced this pull request Nov 7, 2023
@mergify mergify bot merged commit 76522b5 into main Nov 7, 2023
@mergify mergify bot deleted the release-main branch November 7, 2023 17:34
@arya2 arya2 mentioned this pull request Nov 29, 2023
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-release Area: Zebra releases and release management C-cleanup Category: This is a cleanup C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants