-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add(rpc): Add a tonic server in zebra-rpc #8674
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isten address, and initializes the indexer RPC when zebrad starts
…ture is selected, simplifies indexer.proto file, makes tonic deps optional
…PC, and implements a simple version of the chain_tip_change RPC method
…pdates vectors test
21eee5c
to
a5261e6
Compare
oxarbitrage
previously approved these changes
Jul 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just some comment in the default port chosen.
arya2
commented
Jul 15, 2024
oxarbitrage
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to implement the indexer RPC methods in a tonic server to stream responses to its clients.
Closes #8618.
Solution
zebra-grpc
chain_tip_change
method which notifies clients when the best chain tip in Zebra changesTests
Tests that the server starts and the
chain_tip_change
method notifies the client when the best chain tip changes.Follow-up Work
Implement the rest of the
chain_tip_change
methodPR Author's Checklist
PR Reviewer's Checklist