change(tests): Adds timeouts tonic clients in tests #8724
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
test_grpc_methods_mocked
seemed to hang in CI here: https://github.com/ZcashFoundation/zebra/actions/runs/10101606903/job/27935542667?pr=8694#step:12:2915Tonic doesn't add any timeout by default on the server or the client, the test isn't checking for panics in the spawned tokio tasks for handling mock service responses, and the mock service isn't wrapped in a
Timeout
tower layer.Solution
PR Author's Checklist
PR Reviewer's Checklist