Correct coinbase check #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches the check in zcashd/src/primitives/transaction.h:682 (CTransaction::IsCoinBase).
hdevalence
force-pushed
the
correct-coinbase-check
branch
from
eb76995 to
a31818a
Compare
|
This was an ad-hoc check; running through the Zcashd source and itemizing all the consensus rules should be done in other issues. |
yaahc
previously approved these changes
Aug 13, 2020
This matches zcashd/src/main.cpp:3968-3974 in CheckBlock. Previously, the check allowed the first transaction to have multiple coinbase inputs.
They're slices internally so we might as well just expose them that way.
hdevalence
force-pushed
the
correct-coinbase-check
branch
from
a31818a to
2130d3c
Compare
yaahc
approved these changes
Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should probably have tests, I just noticed this while reviewing #763 and it seemed faster to just do the fix rather than write it down.
Edit: