-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: remove experimental features from release builds #9222
base: main
Are you sure you want to change the base?
Conversation
BREAKING CHANGE: Experimental features are no longer built into release images. Users must now build custom images with specific features if needed. - Remove experimental build job from release workflow - Remove experimental features from CI matrix - Update documentation to reflect new feature strategy - Simplify Dockerfile by removing experimental feature args - Keep RUN_ALL_EXPERIMENTAL_TESTS for testing purposes only Migration: Users who need specific features should: 1. Build custom images using --build-arg FEATURES="feature1 feature2" 2. Use the documented feature flags in their builds 3. Refer to the new documentation for building with custom features Closes #9210 Closes #9204 Partially #7415
Enable passing experimental features to Docker test runs by: - Updating workflow configuration to pass EXPERIMENTAL_FEATURES - Modifying entrypoint script to include experimental features during test execution - Documenting new experimental test category in workflow README
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'll be easier if we merge #8923 first since it also simplifies passing Rust features to the images using only a single variable.
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🔴 ⛓️ Depends-On RequirementsThis rule is failing.Requirement based on the presence of
|
Motivation
Experimental features are no longer built into release images. Users must now build custom images with specific features if needed.
Closes #9210
Closes #9204
Partially #7415
Depends-On: #8923
Solution
Notes
Migration: Users who need specific features should:
PR Author's Checklist
PR Reviewer's Checklist