fix(rpc): getblocktemplate coinbase outputs order #9272
+72
−44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In #8099 we realized zcashd always put miner reward output as the first output of the coinbase.
This PR copy that behaviour for the config
debug_like_zcashd
mode of Zebra mining.Close #8099
Solution
Make the miner reward transaction to appear first when using the Zebra getblocktemplate RPC method and the
debug_like_zcashd
flag is on (which is the default).Tests
Existing
rpc_getblocktemplate
was updated to check the miner reward is the first coinbase output.Snapshot tests were updated.
PR Author's Checklist
PR Reviewer's Checklist