build fixes #13
Open
build fixes #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bogus use 'g++'. On some systems 'g++' is more correctly spelled 'g++48' or the like.
boost no longer uses the 'mt' suffix.
make(1) is already chatty for you. You can even make it more verbose. Adding manual echo lines is pointless.
Most users expect CXXFLAGS and LDFLAGS to be used.
rm -f is safe here :))
Without this the C++ code could not compile:
bitcoin_bignum/serialize.h:911:10: error: class member cannot be redeclared
void insert(iterator it, std::vector<char>::const_iterator first, std::vector<char>::const_iterator last)
^
bitcoin_bignum/serialize.h:898:10: note: previous declaration is here
void insert(iterator it, const_iterator first, const_iterator last)
^
The C++ code uses 'long long' which is a C++11 feature, so depend on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows libzerocoin to build in more places. I've almost certainly missed things (e.g., I don't add rpath to LDFLAGS) but this is good enough for now.