-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add modal to dismiss custodial wallet warning #2394
Add modal to dismiss custodial wallet warning #2394
Conversation
0f4f8c2
to
3b65110
Compare
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-09-05.at.20.57.58.mp4Demo video just for the UI update |
After you hit 'Dismiss warning' it should kick you out to the main wallet view |
stores/SettingsStore.ts
Outdated
@action | ||
public dismissWarning = () => { | ||
this.dismissCustodialWarning = true; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as it stands now, this will not persist across restarts of the app. this needs to be saved to local storage on per node/account basis
…able the warning in lndhub nodes
af797b8
to
fec86d0
Compare
0e4388c
to
2cff1ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
Relates to issue: ZEUS-2344
We have added a modal which will dismiss the custodial wallet warning
This pull request is categorized as a:
Checklist
yarn run tsc
and made sure my code compiles correctlyyarn run lint
and made sure my code didn’t contain any problematic patternsyarn run prettier
and made sure my code is formatted correctlyyarn run test
and made sure all of the tests passTesting
If you modified or added a utility file, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
Locales
Third Party Dependencies and Packages
yarn
after this PR is merged inpackage.json
andyarn.lock
have been properly updatedOther: