Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using new react-native-android container for v0.9.1 #2487

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

ktecho
Copy link
Contributor

@ktecho ktecho commented Oct 23, 2024

Related issue: ZEUS-2470

"Reproducible Builds" feature is not working for 0.9.1, so it's also failing at WalletScrutiny. Using a newer (v14.0) container makes it work.

@kaloudis
Copy link
Contributor

"Reproducible Builds" feature is not working for 0.9.1, so it's also failing at WalletScrutiny. Using a newer (v14.0) container makes it work.

While the upgrade is welcome, I don't think things are explicitly broken w the older image. In my experience, we've seen builds have flukes and not have matching hashes on occasion. I suspect there might be some race condition in the build process or dependency-related issue. Just something to keep in mind.

@kaloudis kaloudis added this to the v0.9.2 milestone Oct 23, 2024
@ktecho
Copy link
Contributor Author

ktecho commented Oct 23, 2024

Ah, I don't know about that. I tried twice and it failed, then I used v14.0 and it worked the first time.

@kaloudis
Copy link
Contributor

Ah, I don't know about that. I tried twice and it failed, then I used v14.0 and it worked the first time.

Could you elaborate? If it was an error on build could you please share the error message?

@ktecho
Copy link
Contributor Author

ktecho commented Oct 23, 2024

Ah, I don't know about that. I tried twice and it failed, then I used v14.0 and it worked the first time.

Could you elaborate? If it was an error on build could you please share the error message?

Of course! This is while running build.sh at v0.9.1:

> Task :app:createBundleReleaseJsAndAssets
node:internal/fs/watchers:255
    throw error;
    ^

Error: ENOENT: no such file or directory, watch '/olympus/zeus/node_modules/react-native-vision-camera/android/.cxx/RelWithDebInfo/5b2q5k2o/arm64-v8a/CMakeFiles/CMakeTmp/CMakeFiles/cmTC_620a9.dir'
    at FSWatcher.<computed> (node:internal/fs/watchers:247:19)
    at Object.watch (node:fs:2418:34)
    at NodeWatcher._watchdir (/olympus/zeus/node_modules/metro-file-map/src/watchers/NodeWatcher.js:89:24)
    at /olympus/zeus/node_modules/metro-file-map/src/watchers/NodeWatcher.js:185:22
    at Walker.<anonymous> (/olympus/zeus/node_modules/metro-file-map/src/watchers/common.js:81:31)
    at Walker.emit (node:events:517:28)
    at /olympus/zeus/node_modules/walker/lib/walker.js:69:16
    at FSReqCallback.oncomplete (node:fs:192:23) {
  errno: -2,
  syscall: 'watch',
  code: 'ENOENT',
  path: '/olympus/zeus/node_modules/react-native-vision-camera/android/.cxx/RelWithDebInfo/5b2q5k2o/arm64-v8a/CMakeFiles/CMakeTmp/CMakeFiles/cmTC_620a9.dir',
  filename: '/olympus/zeus/node_modules/react-native-vision-camera/android/.cxx/RelWithDebInfo/5b2q5k2o/arm64-v8a/CMakeFiles/CMakeTmp/CMakeFiles/cmTC_620a9.dir'
}

Node.js v18.19.0

> Task :app:createBundleReleaseJsAndAssets FAILED

> Task :react-native-vision-camera:configureCMakeRelWithDebInfo[arm64-v8a]
C/C++: VisionCamera: Frame Processors: OFF!

> Task :react-native-notifications:generateReactNative60ReleaseLintModel
WARNING: [Processor] Library '/root/.gradle/caches/modules-2/files-2.1/org.robolectric/shadows-framework/4.3/150103d5732c432906f6130b734e7452855dd67b/shadows-framework-4.3.jar' contains references to both AndroidX and old support library. This seems like the library is partially migrated. Jetifier will try to rewrite the library anyway.
 Example of androidX reference: 'androidx/test/runner/lifecycle/Stage'
 Example of support library reference: 'android/support/annotation/NonNull'

> Task :react-native-keychain:extractReleaseAnnotations
Warning: com.oblador.keychain.KeychainModule.AccessControl: The typedef annotation should have @Retention(RetentionPolicy.SOURCE)
Warning: com.oblador.keychain.KeychainModule.KnownCiphers: The typedef annotation should have @Retention(RetentionPolicy.SOURCE)
Warning: com.oblador.keychain.KeychainModule.Rules: The typedef annotation should have @Retention(RetentionPolicy.SOURCE)

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:createBundleReleaseJsAndAssets'.
> Process 'command 'node'' finished with non-zero exit value 1

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org.

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/8.6/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

BUILD FAILED in 4m 53s
1142 actionable tasks: 1142 executed

# reactnativecommunity/react-native-android:13.0
BUILDER_IMAGE="reactnativecommunity/react-native-android@sha256:4ff9c9f80da57c72284900fcfdbd079183e735684c62d7fafd3df50fdb895453"
# reactnativecommunity/react-native-android:14.0
BUILDER_IMAGE="reactnativecommunity/react-native-android@sha256:6607421944d844b82e4d05df50c11dc9fa455108222d63475cd3a0f62465fbda"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so manifest digest is for the specific architecture. index digest is the for the group of images.

index is fine and better to use in general so builds would work with multiple architectures - though in our case react-native-android only has the one

@kaloudis kaloudis merged commit adb4f4d into ZeusLN:master Oct 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants