-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using new react-native-android container for v0.9.1 #2487
Using new react-native-android container for v0.9.1 #2487
Conversation
While the upgrade is welcome, I don't think things are explicitly broken w the older image. In my experience, we've seen builds have flukes and not have matching hashes on occasion. I suspect there might be some race condition in the build process or dependency-related issue. Just something to keep in mind. |
Ah, I don't know about that. I tried twice and it failed, then I used v14.0 and it worked the first time. |
Could you elaborate? If it was an error on build could you please share the error message? |
Of course! This is while running
|
# reactnativecommunity/react-native-android:13.0 | ||
BUILDER_IMAGE="reactnativecommunity/react-native-android@sha256:4ff9c9f80da57c72284900fcfdbd079183e735684c62d7fafd3df50fdb895453" | ||
# reactnativecommunity/react-native-android:14.0 | ||
BUILDER_IMAGE="reactnativecommunity/react-native-android@sha256:6607421944d844b82e4d05df50c11dc9fa455108222d63475cd3a0f62465fbda" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to use the manifest digest here instead of the index digest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so manifest digest is for the specific architecture. index digest is the for the group of images.
index is fine and better to use in general so builds would work with multiple architectures - though in our case react-native-android
only has the one
Related issue: ZEUS-2470
"Reproducible Builds" feature is not working for 0.9.1, so it's also failing at WalletScrutiny. Using a newer (v14.0) container makes it work.