Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android only: Set 'setRecentsScreenshotEnabled' to false to avoid data leak via recents #2502

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

myxmaster
Copy link
Contributor

Description

As of Android 13 we can use setRecentsScreenshotEnabled to avoid data leak via recents.

Before:
grafik

After:
grafik

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (CLNRest)
  • LndHub
  • [DEPRECATED] Core Lightning (c-lightning-REST)
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@myxmaster myxmaster marked this pull request as draft October 31, 2024 00:02
@myxmaster myxmaster force-pushed the setRecentsScreenshotEnabled branch from 6bef331 to 0bfd522 Compare October 31, 2024 00:09
@myxmaster myxmaster marked this pull request as ready for review October 31, 2024 00:09
@kaloudis kaloudis added this to the v0.9.2 milestone Oct 31, 2024
@kaloudis
Copy link
Contributor

@myxmaster
Copy link
Contributor Author

We definitely don't want to forbid making screenshots at all, right? So FLAG_SECURE is not a good option.

But HIDE_OVERLAY_WINDOWS sounds interesting, I didn't know about it or how it works in detail, but might makes sense to use that...

@kaloudis
Copy link
Contributor

We definitely don't want to forbid making screenshots at all, right? So FLAG_SECURE is not a good option.

But HIDE_OVERLAY_WINDOWS sounds interesting, I didn't know about it or how it works in detail, but might makes sense to use that...

Right, we want to let users still be able to take screenshots and record video.

@kaloudis kaloudis merged commit 6aaa6c1 into ZeusLN:master Nov 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants