Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZEUS Pay: update regenerate pre-image flow #2555

Merged
merged 2 commits into from
Nov 24, 2024

Conversation

kaloudis
Copy link
Contributor

Description

Instead of having users shuffle their Nostr keys, let's prompt them to reset their pre-image and hash mapping with a button.

Before:
Screenshot 2024-11-21 at 11 33 50 PM

After:
Simulator Screenshot - iPhone 16 Plus - 2024-11-21 at 23 29 57

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (CLNRest)
  • LndHub
  • [DEPRECATED] Core Lightning (c-lightning-REST)
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis added this to the v0.9.3 milestone Nov 22, 2024
@kaloudis kaloudis force-pushed the zeus-pay-regenerate-flow branch from 55f9df7 to d6d39db Compare November 22, 2024 04:36
@kaloudis kaloudis force-pushed the zeus-pay-regenerate-flow branch from d6d39db to 7b42c85 Compare November 22, 2024 04:39
@kaloudis kaloudis merged commit beeb6b7 into ZeusLN:master Nov 24, 2024
4 checks passed
@kaloudis kaloudis deleted the zeus-pay-regenerate-flow branch November 24, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant