-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call getSettingsAndNavigate less often #2660
base: master
Are you sure you want to change the base?
Call getSettingsAndNavigate less often #2660
Conversation
e6eb541
to
71cfa8b
Compare
Now using observable flag again, because: Removed all the unused route params. |
71cfa8b
to
3a97378
Compare
(rebased and fixed merge conflict) |
3a97378
to
643374c
Compare
rebased/solved conflict |
Description
Before, getSettingsAndNavigate() was called everytime Wallet.tsx gained focus. Since processing getSettingsAndNavigate() takes some time, this resulted in the app not being responsive for a short time. Example: When you closed the menu and then immediately clicked on a balance slider, it was not responding.
With this PR the flow is optimized, so getSettingsAndNavigate() is only called:
Additionally fixed a bug, where autonavigation into POS didn't work in this edge case:
Require login after app returns from background
=> no autonavigate is happening
Root cause was in Lockscreen.tsx, now it is only setting posStatus to 'inactive' when POS is actually enabled.
This pull request is categorized as a:
Checklist
yarn run tsc
and made sure my code compiles correctlyyarn run lint
and made sure my code didn’t contain any problematic patternsyarn run prettier
and made sure my code is formatted correctlyyarn run test
and made sure all of the tests passTesting
If you modified or added a utility file, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
Locales
Third Party Dependencies and Packages
yarn
after this PR is merged inpackage.json
andyarn.lock
have been properly updatedOther: