Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cz-git): incorrect maxSubjectLength on custom scope #173

Merged
merged 4 commits into from
May 25, 2024

Conversation

thansetan
Copy link
Contributor

Related ISSUE

None

Type Of Change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • πŸ“ Document (This change requires a documentation update)
  • 🎨 Theme style (Theme style beautification)
  • ⚠ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • πŸ”¨ Workflow (Workflow changes)

Clear Describe

Fix incorrect maxSubjectLength when using a custom commit scope.

Description

Previously, when using a custom commit scope, the length of ___CUSTOM___ was used to calculate the maxSubjectLength instead of the length of the custom scope itself.

Copy link

netlify bot commented May 22, 2024

βœ… Deploy Preview for cz-git ready!

Name Link
πŸ”¨ Latest commit 039f825
πŸ” Latest deploy log https://app.netlify.com/sites/cz-git/deploys/6651cc1e7c3c07000851d1d2
😎 Deploy Preview https://deploy-preview-173--cz-git.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Zhengqbbb
Copy link
Owner

Zhengqbbb commented May 22, 2024

Oh !!!. Thanks for your contribution, I will review it in the weekend.

@Zhengqbbb Zhengqbbb merged commit baa58ae into Zhengqbbb:main May 25, 2024
10 checks passed
@Zhengqbbb
Copy link
Owner

@thansetan
LFG bro! I have merged into the main branch and released the 1.9.2-beta.1 pre-release version for testing.
You can use the following commands for testing.
If there are any issues, please point them out.
I plan to release 1.9.2 tomorrow.
Thank you for your contribution.

npx or bunx

npx -y czg@next -v
npx -y czg@next

# or
npm install -g czg@next
czg -v
czg

@Zhengqbbb
Copy link
Owner

The latest version 🌟(v1.9.2)🌟 should be resolve this issue request , please have a try. πŸ’ͺ
πŸ‘€ Let me know if there are still any issues. πŸŽ‰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants