Fixed Issue #7 and fixed grammar #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @IQuick143 , thanks for you contribution! The changes look good. There is one doc test that is failing and if you could fix it as well I'll merge your PR. |
|
Okay, I've almost got a fix for that one unit test but I'm still testing if it's good, I'll push it tomorrow. |
|
Fixed the problem, the algorithm was correct but it didn't order the branches of the tree alphabetically like in the unit test. That's fixed now. |
|
Great, tests are passing now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made a fix for the issue about incorrect output I brought up.
All the unit tests included passed, except one which had a problem with the following change in the output:
~^(?#match nothing)is now placed at the beginning of the regex instead of the end, if this is a problem I can alter the algorithm to take care of this edge case.I've changed the corresponding unit test to reflect the new behaviour.
See this commit.
I've also fixed a mistake in the grammar regarding
childrensbecause the correct word should bechildren, if this change seems unnecessary and problematic, tell me.Change in this commit