Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Karazhan: Update timers #238

Merged
merged 5 commits into from
Jan 17, 2025
Merged

Karazhan: Update timers #238

merged 5 commits into from
Jan 17, 2025

Conversation

ForestJ316
Copy link
Contributor

Maiden of Virtue: Add keep arg to Repentance CD
Netherspite: Fix icon texture

Maiden of Virtue: Add keep arg to Repentance CD
Netherspite: Fix icon texture
@Zidras
Copy link
Owner

Zidras commented Jan 12, 2025

Hi @ForestJ316 , do you happen to have a log? DBM now support variant timers, so if variance is somehow known, I'd like to include it with the "keep" arg.

@ForestJ316
Copy link
Contributor Author

Forgot to record a transcriptor log. If I remember to do one then I can post it, sure.

@Zidras
Copy link
Owner

Zidras commented Jan 15, 2025

Forgot to record a transcriptor log. If I remember to do one then I can post it, sure.

Any news? This PR has important fixes, so if you don't have a log, I'll just address the glaring bugs.

@ForestJ316
Copy link
Contributor Author

Seems to be a consistent 33s timer for Repentance.
Logs from current PTR:
maiden pull 1-3.txt
maiden pull 4.txt

@Zidras
Copy link
Owner

Zidras commented Jan 15, 2025

Usually, fixed timers are Next, not CD

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Owner

@Zidras Zidras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the mods was not bumped, but code is good

@Zidras Zidras merged commit 16f8e50 into Zidras:main Jan 17, 2025
1 check passed
@ForestJ316 ForestJ316 deleted the KaraUpdates branch February 13, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants