Karazhan: Update timers #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maiden of Virtue: Add keep arg to Repentance CD Netherspite: Fix icon texture
|
Hi @ForestJ316 , do you happen to have a log? DBM now support variant timers, so if variance is somehow known, I'd like to include it with the "keep" arg. |
|
Forgot to record a transcriptor log. If I remember to do one then I can post it, sure. |
Any news? This PR has important fixes, so if you don't have a log, I'll just address the glaring bugs. |
|
Seems to be a consistent 33s timer for Repentance. |
|
Usually, fixed timers are Next, not CD |
Zidras
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maiden of Virtue: Add keep arg to Repentance CD
Netherspite: Fix icon texture