Stop ignoring broadcasted NewViews
#2064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #2042 added `NewView` broadcasting, but it didn't change anything because nodes ignored `NewView`s that were not sent via a direct request. In fact that PR made network recovery worse, since the leader would no longer see repeated `NewView`s. This PR just adds the handler for broadcasted `NewView`s.
JamesHinshelwood
force-pushed
the
fix-nv
branch
from
cbec182 to
1e5a1bc
Compare
DrZoltanFazekas
approved these changes
Dec 22, 2024
|
Bencher Report| Branch | fix-nv |
| Testbed | self-hosted |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Upper Boundary milliseconds (ms) (Limit %) |
|---|---|---|---|
| process-empty/process-empty | 📈 view plot 🚷 view threshold | 8.49 (-6.98%) | 10.40 (81.68%) |
| produce-full/produce-full | 📈 view plot 🚷 view threshold | 1,743.80 (-15.65%) | 2,744.13 (63.55%) |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #2042 added
NewViewbroadcasting, but it didn't change anything because nodes ignoredNewViews that were not sent via a direct request. In fact that PR made network recovery worse, since the leader would no longer see repeatedNewViews. This PR just adds the handler for broadcastedNewViews.