-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/udpate-pdm-version-docker-file #504
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kirtimanmishrazipstack PDM might be backwards compatible and work with lock files generated with 2.12.3
. In order to do this sanity test correctly, you'll have to update the lock files with PDM 2.16.1. Make sure to also address these changes in the cloud repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - make sure to do a similar update in other repos to be consistent throughout
I notice its usage in cloud and SDK.
LLMWhisperer can be updated too - your thoughts on this @ritwik-g @arun-venkataswamy ?
Quality Gate passedIssues Measures |
|
What
Why
2.16.1
How
2.16.1
locallypdm.lock
file based pdm version2.16.1
Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
Database Migrations
Env Config
Relevant Docs
Related Issues or PRs
Dependencies Versions
Notes on Testing
pdm version 2.16.1
, generatedpdm.lock
file on all services. Also upgraded all dockerFiles with same version.Screenshots
Checklist
I have read and understood the Contribution Guidelines.