Remove "_token" from parseIdentity #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 15, 2014 08:44
94th line, `$repo->login($input)`. In fact, it'll extract username or email from the `$input` as throttle identity However, `$repo->isThrottled($input)` will just use `$input` as throttle identity. so, the throttle identity will never match up resulting in login throttling not working.
|
Thanks @WPPD Also you can give me access to |
|
hi @Zizaco I've added you to the Collaborators list. I think it's best to leave it to you since I'm not good at this thing. |
|
hey @Zizaco I've add Please let me know if you need me to do anything. I'm very new to this. :] |
…ttled since CacheLoginThrottleService::parseIdentity now removes _token
…approach when parsing identity
|
@WPPD The tests are good now! I've made some tweaks in your branch. Thanks again for spotting this problem :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also add a note (or say warning) about login throttle in the UsersController