Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugin-clboss: Unexpected listpeers #192

Closed
farscapian opened this issue Apr 6, 2024 · 14 comments · Fixed by #193
Closed

plugin-clboss: Unexpected listpeers #192

farscapian opened this issue Apr 6, 2024 · 14 comments · Fixed by #193

Comments

@farscapian
Copy link

farscapian commented Apr 6, 2024 •
edited
Loading

I recently upgraded to 24.02 and started experiencing the following issues. I see this error on both NodeBalanceSwapper and EarningsRebalancer. I updated to CLN 24.02.1 and I'm seeing the same result. (I'm running the release-v0.13.1 branch of CLBOSS)

The output suggests unexpected output from listpeers:

lnplay-cln-0_cln-0.1.qd0bv3uuhtpm@librem-mini | Unhandled exception in concurrent task!
lnplay-cln-0_cln-0.1.qd0bv3uuhtpm@librem-mini | Incorrect type.
lnplay-cln-0_cln-0.1.qd0bv3uuhtpm@librem-mini | ...main loop continuing...
lnplay-cln-0_cln-0.1.qd0bv3uuhtpm@librem-mini | 2024-04-06T15:05:51.312Z BROKEN plugin-clboss: NodeBalanceSwapper: Unexpected listpeers: [\n\t{\n\t\t"id" : "03e30da473716d39c09356d5372cf839d8ee3a1cdbd993ee853c23ab9bdfbce6f8",\n\t\t"connected" : true,\n\t\t"num_channels" : 1,\n\t\t"netaddr" : [\n\t\t\t"211.23.128.57:9735"\n\t\t],\n\t\t"features" : "800000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000002000888252a1"\n\t},\n\t{\n\t\t"id" : "03d6f092d9806c189d8fe2475d8a31260e891a861f57c10d742e08c02412767d5e",\n\t\t"connected" : false,\n\t\t"num_channels" : 1,\n\t\t"features" : ""\n\t},\n\t{\n\t\t"id" : "03979d66fa2be1741a92c56707d8b7c0c48d9565ad526f7ce3706202d2250c4218",\n\t\t"connected" : true,\n\t\t"num_channels" : 1,\n\t\t"netaddr" : [\n\t\t\t"5xzvqwv4mcfj5nnoacm54272ooykvohu3x7jfebpbqlss4a2ozz7i3yd.onion:9735"\n\t\t],\n\t\t"features" : "800000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000002000888252a1"\n\t},\n\t{\n\t\t"id" : "03a9b9b4d5bff67fb90d7deaf7db842e3aa5e3abea58fa488a8af3d163679107d7",\n\t\t"connected" : true,\n\t\t"num_channels" : 0,\n\t\t"netaddr" : [\n\t\t\t"118.163.74.161:9735"\n\t\t],\n\t\t"remote_addr" : "99.184.79.163:25103",\n\t\t"features" : "08a0000a0a69a2"\n\t},\n\t{\n\t\t"id" : "027833211bdc28059b323492f2e51453559a2fcbaf947c16f716d060e560128eb2",\n\t\t"connected" : true,\n\t\t"num_channels" : 1,\n\t\t"netaddr" : [\n\t\t\t"10.10.0.2:43300"\n\t\t],\n\t\t"features" : "08a0800a0a69a2"\n\t},\n\t{\n\t\t"id" : "031a33566a118aca7d71c37386fca49004c247810fc4a1dc7c08c2eb982b3c5215",\n\t\t"connected" : false,\n\t\t"num_channels" : 1,\n\t\t"features" : ""\n\t},\n\t{\n\t\t"id" : "0370fb1bb00afce3d161a71e4b71ed19891f9b4d5ff8c7cba83239bc556641fcb5",\n\t\t"connected" : true,\n\t\t"num_channels" : 1,\n\t\t"netaddr" : [\n\t\t\t"7athpxle7bgig4to7xllsmgz6vx6t3r3xnnjg6fhtwfugtpeclyo53id.onion:9735"\n\t\t],\n\t\t"features" : "800000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000002000888a52a1"\n\t},\n\t{\n\t\t"id" : "034f3f792988c43f41c65a839acdfa48647204bb99aca7de426f7c80b0dcf7a4a6",\n\t\t"connected" : true,\n\t\t"num_channels" : 1,\n\t\t"netaddr" : [\n\t\t\t"vbya6gvgslwxjc3bulmvlhukyrl42uzbogwi3qu2uad7eed5nu6oxlqd.onion:9735"\n\t\t],\n\t\t"features" : "80000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000008a000888a52a1"\n\t},\n\t{\n\t\t"id" : "02fe6a27ddcb2dd9fa8479fe1d52549b5932079a493b51f1409fa2c5878f1bc07c",\n\t\t"connected" : true,\n\t\t"num_channels" : 1,\n\t\t"netaddr" : [\n\t\t\t"65.108.134.61:9735"\n\t\t],\n\t\t"remote_addr" : "99.184.79.163:5396",\n\t\t"features" : "08a0002a0a69a2"\n\t},\n\t{\n\t\t"id" : "02d96eadea3d780104449aca5c93461ce67c1564e2e1d73225fa67dd3b997a6018",\n\t\t"connected" : true,\n\t\t"num_channels" : 1,\n\t\t"netaddr" : [\n\t\t\t"45.86.229.190:9736"\n\t\t],\n\t\t"remote_addr" : "99.184.79.163:60267",\n\t\t"features" : "08a0000a8a5961"\n\t},\n\t{\n\t\t"id" : "0399d8b8817ef2623e1bce5ba14727a804b2643dc79c5f352408c67bf18e7ab38a",\n\t\t"connected" : true,\n\t\t"num_channels" : 1,\n\t\t"netaddr" : [\n\t\t\t"4rwjdl7wyt5sgou2sptr3ahakf7geagyptroaors2frbfjfravp726id.onion:9735"\n\t\t],\n\t\t"features" : "80000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000008a000888a52a1"\n\t},\n\t{\n\t\t"id" : "0298f6074a454a1f5345cb2a7c6f9fce206cd0bf675d177cdbf0ca7508dd28852f",\n\t\t"connected" : true,\n\t\t"num_channels" : 0,\n\t\t"netaddr" : [\n\t\t\t"174.169.193.33:9735"\n\t\t],\n\t\t"features" : "08a0000a8a59a1"\n\t},\n\t{\n\t\t"id" : "021f98b9898720f8633c93faf0aa54ab399d277464e502d1111b233c2cf4064828",\n\t\t"connected" : true,\n\t\t"num_channels" : 1,\n\t\t"netaddr" : [\n\t\t\t"155.248.202.151:9735"\n\t\t],\n\t\t"remote_addr" : "99.184.79.163:20491",\n\t\t"features" : "08a0000a0a69a2"\n\t},\n\t{\n\t\t"id" : "029ca15ad2ea3077f5f0524c4c9bc266854c14b9fc81b9cc3d6b48e2460af13f65",\n\t\t"connected" : true,\n\t\t"num_channels" : 1,\n\t\t"netaddr" : [\n\t\t\t"141.95.84.44:9735"\n\t\t],\n\t\t"remote_addr" : "99.184.79.163:14576",\n\t\t"features" : "08a0000a8a59a1"\n\t},\n\t{\n\t\t"id" : "03a5886df676f3b3216a4520156157b8d653e262b520281d8d325c24fd8b456b9c",\n\t\t"connected" : true,\n\t\t"num_channels" : 0,\n\t\t"netaddr" : [\n\t\t\t"188.165.2.4:9737"\n\t\t],\n\t\t"features" : "800000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000002000888252a1"\n\t},\n\t{\n\t\t"id" : "03c8dfbf829eaeb0b6dab099d87fdf7f8faceb0c1b935cd243e8c1fb5af71361cf",\n\t\t"connected" : true,\n\t\t"num_channels" : 1,\n\t\t"netaddr" : [\n\t\t\t"3.234.251.85:9735"\n\t\t],\n\t\t"features" : "800000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000002000888a52a1"\n\t},\n\t{\n\t\t"id" : "03a41f7069f0398d2b91351b8b35b3348de23919810589719aaab1c9458a2d3542",\n\t\t"connected" : true,\n\t\t"num_channels" : 0,\n\t\t"netaddr" : [\n\t\t\t"10.10.0.2:44140"\n\t\t],\n\t\t"features" : "0000000000000000"\n\t}\n]
lnplay-cln-0_cln-0.1.qd0bv3uuhtpm@librem-mini | 2024-04-06T15:05:51.314Z BROKEN plugin-clboss: EarningsRebalancer: Unexpected result from listpeers: [\n\t{\n\t\t"id" : "03e30da473716d39c09356d5372cf839d8ee3a1cdbd993ee853c23ab9bdfbce6f8",\n\t\t"connected" : true,\n\t\t"num_channels" : 1,\n\t\t"netaddr" : [\n\t\t\t"211.23.128.57:9735"\n\t\t],\n\t\t"features" : "800000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000002000888252a1"\n\t},\n\t{\n\t\t"id" : "03d6f092d9806c189d8fe2475d8a31260e891a861f57c10d742e08c02412767d5e",\n\t\t"connected" : false,\n\t\t"num_channels" : 1,\n\t\t"features" : ""\n\t},\n\t{\n\t\t"id" : "03979d66fa2be1741a92c56707d8b7c0c48d9565ad526f7ce3706202d2250c4218",\n\t\t"connected" : true,\n\t\t"num_channels" : 1,\n\t\t"netaddr" : [\n\t\t\t"5xzvqwv4mcfj5nnoacm54272ooykvohu3x7jfebpbqlss4a2ozz7i3yd.onion:9735"\n\t\t],\n\t\t"features" : "800000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000002000888252a1"\n\t},\n\t{\n\t\t"id" : "03a9b9b4d5bff67fb90d7deaf7db842e3aa5e3abea58fa488a8af3d163679107d7",\n\t\t"connected" : true,\n\t\t"num_channels" : 0,\n\t\t"netaddr" : [\n\t\t\t"118.163.74.161:9735"\n\t\t],\n\t\t"remote_addr" : "99.184.79.163:25103",\n\t\t"features" : "08a0000a0a69a2"\n\t},\n\t{\n\t\t"id" : "027833211bdc28059b323492f2e51453559a2fcbaf947c16f716d060e560128eb2",\n\t\t"connected" : true,\n\t\t"num_channels" : 1,\n\t\t"netaddr" : [\n\t\t\t"10.10.0.2:43300"\n\t\t],\n\t\t"features" : "08a0800a0a69a2"\n\t},\n\t{\n\t\t"id" : "031a33566a118aca7d71c37386fca49004c247810fc4a1dc7c08c2eb982b3c5215",\n\t\t"connected" : false,\n\t\t"num_channels" : 1,\n\t\t"features" : ""\n\t},\n\t{\n\t\t"id" : "0370fb1bb00afce3d161a71e4b71ed19891f9b4d5ff8c7cba83239bc556641fcb5",\n\t\t"connected" : true,\n\t\t"num_channels" : 1,\n\t\t"netaddr" : [\n\t\t\t"7athpxle7bgig4to7xllsmgz6vx6t3r3xnnjg6fhtwfugtpeclyo53id.onion:9735"\n\t\t],\n\t\t"features" : "800000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000002000888a52a1"\n\t},\n\t{\n\t\t"id" : "034f3f792988c43f41c65a839acdfa48647204bb99aca7de426f7c80b0dcf7a4a6",\n\t\t"connected" : true,\n\t\t"num_channels" : 1,\n\t\t"netaddr" : [\n\t\t\t"vbya6gvgslwxjc3bulmvlhukyrl42uzbogwi3qu2uad7eed5nu6oxlqd.onion:9735"\n\t\t],\n\t\t"features" : "80000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000008a000888a52a1"\n\t},\n\t{\n\t\t"id" : "02fe6a27ddcb2dd9fa8479fe1d52549b5932079a493b51f1409fa2c5878f1bc07c",\n\t\t"connected" : true,\n\t\t"num_channels" : 1,\n\t\t"netaddr" : [\n\t\t\t"65.108.134.61:9735"\n\t\t],\n\t\t"remote_addr" : "99.184.79.163:5396",\n\t\t"features" : "08a0002a0a69a2"\n\t},\n\t{\n\t\t"id" : "02d96eadea3d780104449aca5c93461ce67c1564e2e1d73225fa67dd3b997a6018",\n\t\t"connected" : true,\n\t\t"num_channels" : 1,\n\t\t"netaddr" : [\n\t\t\t"45.86.229.190:9736"\n\t\t],\n\t\t"remote_addr" : "99.184.79.163:60267",\n\t\t"features" : "08a0000a8a5961"\n\t},\n\t{\n\t\t"id" : "0399d8b8817ef2623e1bce5ba14727a804b2643dc79c5f352408c67bf18e7ab38a",\n\t\t"connected" : true,\n\t\t"num_channels" : 1,\n\t\t"netaddr" : [\n\t\t\t"4rwjdl7wyt5sgou2sptr3ahakf7geagyptroaors2frbfjfravp726id.onion:9735"\n\t\t],\n\t\t"features" : "80000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000008a000888a52a1"\n\t},\n\t{\n\t\t"id" : "0298f6074a454a1f5345cb2a7c6f9fce206cd0bf675d177cdbf0ca7508dd28852f",\n\t\t"connected" : true,\n\t\t"num_channels" : 0,\n\t\t"netaddr" : [\n\t\t\t"174.169.193.33:9735"\n\t\t],\n\t\t"features" : "08a0000a8a59a1"\n\t},\n\t{\n\t\t"id" : "021f98b9898720f8633c93faf0aa54ab399d277464e502d1111b233c2cf4064828",\n\t\t"connected" : true,\n\t\t"num_channels" : 1,\n\t\t"netaddr" : [\n\t\t\t"155.248.202.151:9735"\n\t\t],\n\t\t"remote_addr" : "99.184.79.163:20491",\n\t\t"features" : "08a0000a0a69a2"\n\t},\n\t{\n\t\t"id" : "029ca15ad2ea3077f5f0524c4c9bc266854c14b9fc81b9cc3d6b48e2460af13f65",\n\t\t"connected" : true,\n\t\t"num_channels" : 1,\n\t\t"netaddr" : [\n\t\t\t"141.95.84.44:9735"\n\t\t],\n\t\t"remote_addr" : "99.184.79.163:14576",\n\t\t"features" : "08a0000a8a59a1"\n\t},\n\t{\n\t\t"id" : "03a5886df676f3b3216a4520156157b8d653e262b520281d8d325c24fd8b456b9c",\n\t\t"connected" : true,\n\t\t"num_channels" : 0,\n\t\t"netaddr" : [\n\t\t\t"188.165.2.4:9737"\n\t\t],\n\t\t"features" : "800000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000002000888252a1"\n\t},\n\t{\n\t\t"id" : "03c8dfbf829eaeb0b6dab099d87fdf7f8faceb0c1b935cd243e8c1fb5af71361cf",\n\t\t"connected" : true,\n\t\t"num_channels" : 1,\n\t\t"netaddr" : [\n\t\t\t"3.234.251.85:9735"\n\t\t],\n\t\t"features" : "800000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000002000888a52a1"\n\t},\n\t{\n\t\t"id" : "03a41f7069f0398d2b91351b8b35b3348de23919810589719aaab1c9458a2d3542",\n\t\t"connected" : true,\n\t\t"num_channels" : 0,\n\t\t"netaddr" : [\n\t\t\t"10.10.0.2:44140"\n\t\t],\n\t\t"features" : "0000000000000000"\n\t}\n]
@ksedgwic
Copy link
Collaborator

ksedgwic commented Apr 6, 2024

Wow, I think I have a clue here. I don't see this error in my log, but a prior crash in plugin-pay (reported ElementsProject/lightning#7197) might have the exact same root cause!

Looking at the throw you are seeing, it captures any throws in this code:
https://github.com/ZmnSCPxj/clboss/blob/release-v0.13.1/Boss/Mod/NodeBalanceSwapper.cpp#L50-L75

I think the:

						/* Skip unpublished channels,
						 * they cannot be used for
						 * forwarding anyway.
						 */
						if (chan["private"])
							continue;

is the likely culprit.

And a missing chan->private is what is indicated in ElementsProject/lightning#7197 as well!

Looking at chan::private now ...

@ksedgwic
Copy link
Collaborator

ksedgwic commented Apr 6, 2024

I think this is what caused it:
ElementsProject/lightning@4e086f2

@ksedgwic
Copy link
Collaborator

ksedgwic commented Apr 6, 2024

Ah, this is even more likely!
ElementsProject/lightning@37ccca5

@ksedgwic
Copy link
Collaborator

ksedgwic commented Apr 6, 2024

I'm not sure how our listpeers info is seeing any channels since v24.02 ... maybe it is not, checking ...

I'm inclined to remove the private field check immediately, I've seen this in multiple places now and am pretty sure we aren't supposed to see private channels in this list anymore so the check isn't needed.

@ksedgwic
Copy link
Collaborator

ksedgwic commented Apr 6, 2024

I think the RPC interface inserts the "private" field to responses here:
https://github.com/ElementsProject/lightning/blob/7d8c7230180e60a0e4ac83ba4478527a74848272/lightningd/peer_control.c#L982-L984

Maybe there is a path or circumstance where this data is generated (somewhwere else) w/o the private field)

I still see see channels in the lightning-cli listpeers JSON text output, so I don't completely understand the earlier commit reference that says it is removing channels from listpeers ...

@ksedgwic ksedgwic mentioned this issue Apr 6, 2024
Merged
@ksedgwic
Copy link
Collaborator

ksedgwic commented Apr 6, 2024

@farscapian can you try out the branch for #193 (release-v0.13.1-no-private) ... let's see if this fixes your issue ...

@ksedgwic
Copy link
Collaborator

ksedgwic commented Apr 6, 2024

@farscapian Apologies, I botched the PR, pls make sure you are using 2f09bce

@ghost
Copy link

ghost commented Apr 6, 2024 •
edited by ghost
Loading

I have 24.02.1 running and still have "private" in listpeers, or am I looking at the wrong value?

{
   "peers": [
      {
         "id": "...",
         "connected": true,
         "num_channels": 1,
         "netaddr": [
            "...:9735"
         ],
         "features": "80000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000
000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000
0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000002000888a52a1",
         "channels": [
            {
               "state": "CHANNELD_NORMAL",
               "scratch_txid": "...",
               "last_tx_fee_msat": 1112000,
               "lost_state": false,
               "feerate": {
                  "perkw": 1535,
                  "perkb": 6140
               },
               "owner": "channeld",
               "short_channel_id": "...",
               "direction": 1,
               "channel_id": "...",
               "funding_txid": "...",
               "funding_outnum": 0,
               "close_to_addr": "...",
               "close_to": "...",
               "private": true,
			   
			   
			   ...

@farscapian
Copy link
Author

farscapian commented Apr 6, 2024 •
edited
Loading

I wonder if any of the experimental options would affect that private output? I had dual-fund and splicing enabled. I also have I also have --allow-deprecated-apis=false, so maybe that's enforcing the new standards?

@farscapian
Copy link
Author

@farscapian can you try out the branch for #193 (release-v0.13.1-no-private) ... let's see if this fixes your issue ...

@ksedgwic These changes dont' seen to have an effect. I'm confirmed on CLN v24.02.1 with this CLBOSS branch. Still getting the error below:

lnplay-cln-0_cln-0.1.dkeescyrfmv6@librem-mini | Unhandled exception in concurrent task!2024-04-06T23:46:01.467Z INFO plugin-clboss: New block at 838028
lnplay-cln-0_cln-0.1.dkeescyrfmv6@librem-mini |
lnplay-cln-0_cln-0.1.dkeescyrfmv6@librem-mini | Incorrect type.
lnplay-cln-0_cln-0.1.dkeescyrfmv6@librem-mini | ...main loop continuing...
lnplay-cln-0_cln-0.1.dkeescyrfmv6@librem-mini | 2024-04-06T23:46:01.469Z BROKEN plugin-clboss: NodeBalanceSwapper: Unexpected listpeers: [\n\t{\n\t\t"id" : "027833211bdc28059b323492f2e51453559a2fcbaf947c16f716d060e560128eb2",\n\t\t"connected" : false,\n\t\t"num_channels" : 1,\n\t\t"features" : ""\n\t},\n\t{\n\t\t"id" : "03e30da473716d39c09356d5372cf839d8ee3a1cdbd993ee853c23ab9bdfbce6f8",\n\t\t"connected" : false,\n\t\t"num_channels" : 1,\n\t\t"features" : "800000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000002000888252a1"\n\t},\n\t{\n\t\t"id" : "0399d8b8817ef2623e1bce5ba14727a804b2643dc79c5f352408c67bf18e7ab38a",\n\t\t"connected" : false,\n\t\t"num_channels" : 1,\n\t\t"features" : ""\n\t},\n\t{\n\t\t"id" : "03979d66fa2be1741a92c56707d8b7c0c48d9565ad526f7ce3706202d2250c4218",\n\t\t"connected" : false,\n\t\t"num_channels" : 1,\n\t\t"features" : "800000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000002000888252a1"\n\t},\n\t{\n\t\t"id" : "034f3f792988c43f41c65a839acdfa48647204bb99aca7de426f7c80b0dcf7a4a6",\n\t\t"connected" : false,\n\t\t"num_channels" : 1,\n\t\t"features" : "80000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000008a000888a52a1"\n\t},\n\t{\n\t\t"id" : "02d96eadea3d780104449aca5c93461ce67c1564e2e1d73225fa67dd3b997a6018",\n\t\t"connected" : false,\n\t\t"num_channels" : 1,\n\t\t"features" : ""\n\t},\n\t{\n\t\t"id" : "0370fb1bb00afce3d161a71e4b71ed19891f9b4d5ff8c7cba83239bc556641fcb5",\n\t\t"connected" : false,\n\t\t"num_channels" : 1,\n\t\t"features" : "800000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000002000888a52a1"\n\t},\n\t{\n\t\t"id" : "03c8dfbf829eaeb0b6dab099d87fdf7f8faceb0c1b935cd243e8c1fb5af71361cf",\n\t\t"connected" : false,\n\t\t"num_channels" : 1,\n\t\t"features" : "800000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000002000888a52a1"\n\t},\n\t{\n\t\t"id" : "0224818c362a6e6886ed1d233047dd45dd78c329e1eb20af5de9b8cf6d279c2de6",\n\t\t"connected" : false,\n\t\t"num_channels" : 1,\n\t\t"features" : "08aa800a0269a2"\n\t},\n\t{\n\t\t"id" : "02fe6a27ddcb2dd9fa8479fe1d52549b5932079a493b51f1409fa2c5878f1bc07c",\n\t\t"connected" : false,\n\t\t"num_channels" : 1,\n\t\t"features" : "08a0002a0a69a2"\n\t},\n\t{\n\t\t"id" : "03d6f092d9806c189d8fe2475d8a31260e891a861f57c10d742e08c02412767d5e",\n\t\t"connected" : false,\n\t\t"num_channels" : 1,\n\t\t"features" : ""\n\t},\n\t{\n\t\t"id" : "029ca15ad2ea3077f5f0524c4c9bc266854c14b9fc81b9cc3d6b48e2460af13f65",\n\t\t"connected" : false,\n\t\t"num_channels" : 1,\n\t\t"features" : "08a0000a8a59a1"\n\t},\n\t{\n\t\t"id" : "021f98b9898720f8633c93faf0aa54ab399d277464e502d1111b233c2cf4064828",\n\t\t"connected" : false,\n\t\t"num_channels" : 1,\n\t\t"features" : "08a0000a0a69a2"\n\t}\n]

@farscapian
Copy link
Author

When I run a listpeers on this node, I get the following: notice unlike @martinneustein , this output does not contain channels.

./lightning-cli.sh listpeers
{
"peers": [
{
"id": "0224818c362a6e6886ed1d233047dd45dd78c329e1eb20af5de9b8cf6d279c2de6",
"connected": true,
"num_channels": 1,
"netaddr": [
"192.168.100.31:9735"
],
"features": "08aa800a0269a2"
},
{
"id": "02d96eadea3d780104449aca5c93461ce67c1564e2e1d73225fa67dd3b997a6018",
"connected": true,
"num_channels": 1,
"netaddr": [
"45.86.229.190:9736"
],
"remote_addr": "99.184.79.163:64193",
"features": "08a0000a8a5961"
},
{
"id": "0370fb1bb00afce3d161a71e4b71ed19891f9b4d5ff8c7cba83239bc556641fcb5",
"connected": true,
"num_channels": 1,
"netaddr": [
"7athpxle7bgig4to7xllsmgz6vx6t3r3xnnjg6fhtwfugtpeclyo53id.onion:9735"
],
"features": "800000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000002000888a52a1"
},
{
"id": "03a41f7069f0398d2b91351b8b35b3348de23919810589719aaab1c9458a2d3542",
"connected": true,
"num_channels": 0,
"netaddr": [
"10.10.0.2:55092"
],
"features": "0000000000000000"
},
{
"id": "0298f6074a454a1f5345cb2a7c6f9fce206cd0bf675d177cdbf0ca7508dd28852f",
"connected": true,
"num_channels": 0,
"netaddr": [
"174.169.193.33:9735"
],
"features": "08a0000a8a59a1"
},
{
"id": "02fe6a27ddcb2dd9fa8479fe1d52549b5932079a493b51f1409fa2c5878f1bc07c",
"connected": true,
"num_channels": 1,
"netaddr": [
"65.108.134.61:9735"
],
"remote_addr": "99.184.79.163:49569",
"features": "08a0002a0a69a2"
},
{
"id": "03d6f092d9806c189d8fe2475d8a31260e891a861f57c10d742e08c02412767d5e",
"connected": false,
"num_channels": 1,
"features": ""
},
{
"id": "028c8c9b0b588d00afabe905799aee0225a9315cdb63d7646b7ff7cf02fe4bf643",
"connected": true,
"num_channels": 0,
"netaddr": [
"197.155.6.43:9735"
],
"features": "80000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000200088825161"
},
{
"id": "021f98b9898720f8633c93faf0aa54ab399d277464e502d1111b233c2cf4064828",
"connected": true,
"num_channels": 1,
"netaddr": [
"155.248.202.151:9735"
],
"remote_addr": "99.184.79.163:15097",
"features": "08a0000a0a69a2"
},
{
"id": "03e30da473716d39c09356d5372cf839d8ee3a1cdbd993ee853c23ab9bdfbce6f8",
"connected": true,
"num_channels": 1,
"netaddr": [
"211.23.128.57:9735"
],
"features": "800000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000002000888252a1"
},
{
"id": "0399d8b8817ef2623e1bce5ba14727a804b2643dc79c5f352408c67bf18e7ab38a",
"connected": true,
"num_channels": 1,
"netaddr": [
"4rwjdl7wyt5sgou2sptr3ahakf7geagyptroaors2frbfjfravp726id.onion:9735"
],
"features": "80000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000008a000888a52a1"
},
{
"id": "03979d66fa2be1741a92c56707d8b7c0c48d9565ad526f7ce3706202d2250c4218",
"connected": true,
"num_channels": 1,
"netaddr": [
"5xzvqwv4mcfj5nnoacm54272ooykvohu3x7jfebpbqlss4a2ozz7i3yd.onion:9735"
],
"features": "800000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000002000888252a1"
},
{
"id": "034f3f792988c43f41c65a839acdfa48647204bb99aca7de426f7c80b0dcf7a4a6",
"connected": true,
"num_channels": 1,
"netaddr": [
"vbya6gvgslwxjc3bulmvlhukyrl42uzbogwi3qu2uad7eed5nu6oxlqd.onion:9735"
],
"features": "80000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000008a000888a52a1"
},
{
"id": "03c8dfbf829eaeb0b6dab099d87fdf7f8faceb0c1b935cd243e8c1fb5af71361cf",
"connected": true,
"num_channels": 1,
"netaddr": [
"3.234.251.85:9735"
],
"features": "800000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000002000888a52a1"
},
{
"id": "029ca15ad2ea3077f5f0524c4c9bc266854c14b9fc81b9cc3d6b48e2460af13f65",
"connected": true,
"num_channels": 1,
"netaddr": [
"141.95.84.44:9735"
],
"remote_addr": "99.184.79.163:43663",
"features": "08a0000a8a59a1"
},
{
"id": "027833211bdc28059b323492f2e51453559a2fcbaf947c16f716d060e560128eb2",
"connected": true,
"num_channels": 1,
"netaddr": [
"10.10.0.2:37618"
],
"features": "08a0800a0a69a2"
}
]
}

@farscapian
Copy link
Author

Ok, my apologies everyone. Setting --allow-deprecated-apis=true resolves this issue. Is there some check that should occur in the initialization of CLBOSS to ensure --allow-deprecated-apis=1?

@vincenzopalazzo
Copy link
Contributor

Ok I am the main author of this mess in cln sorry about that. This is the problem https://github.com/ElementsProject/lightning/pull/5825/commits and @ksedgwic suggested.

You can still work with clboss if you enable i-promise-to-fix-broken-api-user in your config, I never use it but I am sure that there is something in our cln docs

@ksedgwic
Copy link
Collaborator

Fixed in v0.13.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove references to the "private" field of channel info returned from listpeers RPC ZmnSCPxj/clboss
3 participants
@ksedgwic @vincenzopalazzo @farscapian