remove references to the "private" field of channel info returned from listpeers RPC #193
Conversation
Fixes issue ([ZmnSCPxj#193]) Changelog-Fixed: Removed references to deprecated "private" field of channel info returned from API.
Fixes issue ([#193]) Changelog-Fixed: Removed references to deprecated "private" field of channel info returned from API.
|
@vincenzopalazzo if you get a chance could you look this change over? |
| @@ -53,17 +53,15 @@ class DummyEarningsManager { | |||
| */ | |||
There was a problem hiding this comment.
Maybe this PR is a good way to remind us that listpeerchannels is now a way to iterate over all the channels?
| @@ -182,11 +182,6 @@ class InitialRebalancer::Impl::Run::Impl | |||
|
|
|||
| auto cs = p["channels"]; | |||
There was a problem hiding this comment.
if a user run deprecated-api = false, this object is null
from cln docs of listpeers: channels (array of objects, optional) deprecated in v23.02, removed after v24.02
| @@ -157,11 +157,6 @@ class EarningsRebalancer::Impl { | |||
| )); | |||
|
|
|||
| for (auto c : p["channels"]) { | |||
|
@vincenzopalazzo should we add the |
|
Now sure @ksedgwic we can do this in multiple PR? |
I'm not sure if you are asking or answering ... if this PR is safe (won't break anything in any circumstance) and effective (doesn't crash when there is no But I'm not confident I understand when the
It feel like with both https://github.com/ZmnSCPxj/clboss/issues and ElementsProject/lightning#7197 we are mostly not missing the private field and then occasionally in special circumstances it is missing. |
Oh sorry :) for me ether way it is fine, we should just remember to migrate at some point! and you are right I think your pr is fixing the crash and you be ok to merge imho |
Fixes issue ([ZmnSCPxj#193]) Changelog-Fixed: Removed references to deprecated "private" field of channel info returned from API.
Fixes issue ([#193]) Changelog-Fixed: Removed references to deprecated "private" field of channel info returned from API.
Maybe fixes #192
The private field has been removed because the private channels are no longer supposed to show up in the list:
ElementsProject/lightning@37ccca5
Since we were always checking private to skip the channel it seems safe to simply not check for it anymore ...