Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protocol bug - cgi-bin discover #231

Closed
aljabr opened this issue Apr 23, 2016 · 3 comments
Closed

protocol bug - cgi-bin discover #231

aljabr opened this issue Apr 23, 2016 · 3 comments
Labels

Comments

@aljabr
Copy link
Contributor

aljabr commented Apr 23, 2016

if i didn't but the
http:// before the URL
i get
undefined://undefined/cgi-bin-zm

@pliablepixels pliablepixels changed the title the cgi-bin discover protocol bug - cgi-bin discover Apr 23, 2016
@pliablepixels
Copy link
Member

pliablepixels commented Apr 23, 2016

can you tell me the exact steps you did to replicate this issue? If you added your portal url, admin id and password, hit save and tapped on cgi-bin discover it should have automatically added the protocol and if you did not, it should have told you you are not logged in. So I am curious what exact steps led to this.

@aljabr
Copy link
Contributor Author

aljabr commented Apr 23, 2016

the issue only show if i didn't put the protocol
the protocol only will added automatically when i try to save it
i think the issue it should add the protocol automatically when i hit discover
it's not that big issue but i think most of people forgets to add the protocol or get lazy :)

@pliablepixels
Copy link
Member

Right, so I actually have a safeguard for that:
https://github.com/pliablepixels/zmNinja/blob/master/www/js/LoginCtrl.js#L266-L276

If you are using this feature to set up zmNinja, those lines will detect that you are not logged in and will
prompt you to Save first (as its only possible to detect after you log into the portal)

I think what happened in your case is, you were already logged in using previous credentials, then you went to Login Settings and changed the URL to test - and did not put a protocol, which resulted in this situation. Is that correct ? If so, I'll fix that scenario. If not, please let me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants