languages with non-english numbers break events/timeline feeds

[aljabr]

Platform & OS Version
all

nature of your issue

i am trying to add some more languages
and they use Hindi digits that can make change in the date and time
i think the events path depends on the date

this make the URL of event don't work

is there any way to detach the localization from the event path?

Details
in Arabic and all language that use Hindi digits

[1668:918939]
VIDEO IS http://192.168.1.100/zm/events/22/١٦/٠٩/١٢/١٢/٠٠/٠٠/7712-video.mp4

the English
[1668:918939]
VIDEO IS http://192.168.1.100/zm/events/5/16/09/12/12/00/00/7713-video.mp4

Thanks

[pliablepixels]

@aljabr - can you check out the latest code and let me know what you see?

[aljabr]

it's working 💃
put i think timeline have the same issue :(

thanks 😗

[pliablepixels]

check now

[aljabr]

it's working

[pliablepixels]

sounds good. Do you plan to contribute the new languages?

[aljabr]

yes i just started
but right now i need to make sure my translation is correct before i submit it
my spelling is so bad even in my native language 😆

i think there is some issue that's need to but some variables inside the local files
like
if i want to translate
1 minute ago
in Arabic
it's wrong to put it like this
should be
ago 1 minute

what i mean is some time is no good to translate each word not all language are the same sort

but I'll contribute any thing i can do 🙆‍♀️

and do you think is best when you add a new translation in local-en file
to but it in last row

i think this will help

[pliablepixels]

On the 'ago' part, I agree. It's not a perfect solution today.

I like to sort the keys in the language files. You can always use checklang.py to see what is different and sort it as well. Refer to the README

[pliablepixels]

@aljabr okay I found a solution to the "ago" problem.

[aljabr]

yest it's better now it's dynamic 💃

can i contribute with the keys or you briefer only with the translate ?
actually i am afraid to ruin your loacal-en.json file 😆

[pliablepixels]

Not sure what you mean.
When you add a language, you create a new file. You do not need to touch locale-en.json

For example, lets say you want to contribute arabic:

1. Create a file locale-ar.json
2. Copy paste contents of locale-en.json into locale-ar.json
3. Translate all the values
4. Run checklang.py -f locale-ar.json - if it says all is ok, run checklang.py -b -o -f locale-ar.json - that will sort and organize your file. Create a PR
5. go to lang/help, create help-ar.json, copy paste help-en.json contents into it, translate. PR.

[aljabr]

no i mean if i found new value need to translate like "exit event view"
do you want me to add it in the local-en or just translate what in the local-en
any way ill push the Arabic Lang soon once i finished

thank you 😚

[pliablepixels]

ah, fixed! feel free to let me know if I missed keys in -en and I'll fix them

[aljabr]

i made deep debug and i found the only missing is
the latest summery and the dates filter 🌝

i fixed like what you did before
i added
.locale('en').format("YYYY-MM-DD") + " " + mFromDate.locale('en').format("HH:mm:ss");

.locale('en').format("YYYY-MM-DD") + " " + mToDate
.locale('en').format("HH:mm:ss");
in

EventCtrl.js

but i don't know if it's the right way to fix it 😄

[pliablepixels]

Looks good. Please PR it too.

On Monday, September 12, 2016, aljabr [email protected] wrote:

i made deep debug and i found the only missing is
the latest summery and the dates filter 🌝

i fixed like what you did before
i added
.locale('en').format("YYYY-MM-DD") + " " + mFromDate.locale('en').format(
"HH:mm:ss");

.locale('en').format("YYYY-MM-DD") + " " + mToDate
.locale('en').format("HH:mm:ss");
in

EventCtrl.js

but i don't know if it's the right way to fix it 😄

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/pliablepixels/zmNinja/issues/325#issuecomment-246528282,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AD7QriYXUNZ8F1GRT7fUjpVB5-0NG8yFks5qpeEqgaJpZM4J6Z9_
.

[pliablepixels]

actually, I'm not sure if I am using $rootScope.from/toString to display any data. If I am, they will show in english. Let me do a change and please see if it works for you.

[pliablepixels]

@aljabr - please test latest changes to see if it fixes the issue above. I am on a flight, can't test with my server.

[aljabr]

OK I'll test it now

i am transiting in Arabic before i submit PL

[aljabr]

doesn't work :( the event stooped working it was working before
revert to the last commit ill PL soon the last fix was working only the issue with the date filter and latest events
and ill include my fix on my PL

[pliablepixels]

fixed the error

[aljabr]

OK I'll test now

[aljabr]

it's working 💃
i am trying to make PL for the Arabic Lang this is my first time to PL 😆

[aljabr]

I'll complete the translation after i wake up :)

[pliablepixels]

@aljabr - great job. I've manually merged the .js changes and .en changes (some of the .js changes are not needed as I fixed the events translation earlier.

Can you close the current PR and do a new PR with just the fully translated arabic file when its ready?

[pliablepixels]

@aljabr - any update to your arabic language file? I plan to make a new release soon.

[aljabr]

Hi sorry for the delay my hard drive that run my operation system get broken :(
and i get busy with my job this days
i'll continue soon i'll try my best to make it today maybe i can't make a PR because my internet speed poor
and i need to setup evrey thing from scratch :(
i'll email you the local-ar
thank you and again sorry for the delay 😢