Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide credentials of simple auth in display #363

Closed
abishai opened this issue Nov 7, 2016 · 5 comments
Closed

Hide credentials of simple auth in display #363

abishai opened this issue Nov 7, 2016 · 5 comments

Comments

@abishai
Copy link

abishai commented Nov 7, 2016

I think, that it would be nice to hide credentials part of ZM url (like https://login:[email protected]), like browsers do. Trivial fix can be just astericks.

@pliablepixels
Copy link
Member

Browsers hide it in the input field, like zmNinja does. Not while sending it over the wire.

@abishai
Copy link
Author

abishai commented Nov 7, 2016

But zmNinja doesn't. Well, at least I see password in url.

@pliablepixels
Copy link
Member

pliablepixels commented Nov 7, 2016

You can't hide the password in basic auth if its part of the URL.
You are likely confusing what you see on the screen (stars) vs. what is sent on the network

If you send user:***@foo.com as basic auth, the password cannot be interpreted. No browser does this either

@abishai
Copy link
Author

abishai commented Nov 7, 2016

Well, ofc, I'm asking to mask it cosmetically.
Now, in ZM portal url (and for cgi-bin and api) we can see full url, with login and password.

@pliablepixels pliablepixels changed the title [DESKTOP] Hide credentials of simple auth Hide credentials of simple auth in display Nov 11, 2016
pliablepixels added a commit that referenced this issue Jan 11, 2017
@pliablepixels
Copy link
Member

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants