Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up event handlers (memory leaks) #611

Closed
pliablepixels opened this issue Apr 14, 2018 · 0 comments
Closed

clean up event handlers (memory leaks) #611

pliablepixels opened this issue Apr 14, 2018 · 0 comments
Labels
bug core rework

Comments

@pliablepixels
Copy link
Member

I was using $rootScope.emit and $rootScope.$on in views and not cleanup. Obviously, memory leaks here. I've now changed to $rootScope.broadcast and $scope.$on. For some reason, manual deregistering of rotoscope on was not fully working.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug core rework
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pliablepixels