Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time not properly displayed in the event modal when selecting 'next event' #649

Closed
neillbell opened this issue Jun 13, 2018 · 1 comment
Closed
Labels

Comments

@neillbell
Copy link
Contributor

Platform & OS Version
Linux x64 & Ubuntu 16.04

The version of the app you are reporting:
1.3.005D

Device details:
Desktop

What is the nature of your issue
Bug

Details
When viewing events in the event modal, clicking "next event" does not properly set the displayed time. The human readable part is correct, but the time displayed is always of the first event displayed with the modal.

Looking through the code, it appears that videoDynamicTime is not being properly set because the $scope.event object is not being set to the new event when moving to the next event.

Here's a diff of a change I made that appears to fix the problem. I don't know the code well enough to know if the fix is appropriate.

diff --git a/www/js/EventModalCtrl.js b/www/js/EventModalCtrl.js
index 6f5f53b..76343f0 100644
--- a/www/js/EventModalCtrl.js
+++ b/www/js/EventModalCtrl.js
@@ -1801,6 +1801,8 @@ angular.module('zmApp.controllers').controller('EventModalCtrl', ['$scope', '$ro
           var event = success.data.event;
           currentEvent = event;
 
+          $scope.event = event;
+        
           computeAlarmFrames(success.data);
           $scope.eventWarning = '';

@pliablepixels
Copy link
Member

Good catch, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants