Plasma 6 compatibility

[guiodic]

Hi, is an update planned for Plasma 6?

Thank you!

[guiodic]

Plasma 6 was released today. I hope this decoration can be updated to the new DE. Thank you!

[guiodic]

Sorry, a gentle bump :)

[AntarEspadas]

I am also curious if an update is planned

[abolast]

I regret not having learned C++. C++ is too difficult.
Similarly, this tool can improve my work efficiency.

[guiodic]

I am seeing that @Zren is prioritizing widgets, I hope he has time for this decoration, much of the work I think has already been done. I really can't get by without the LIM!

[nicman23]

I am independently working on it, I just need to figure out kconfig but it is so boring as I do not use the kconfig menu, as I always just changed the source code

[guiodic]

Thank you very much! Il mar 9 apr 2024, 12:19 nicman23 ***@***.***> ha scritto:

…

I am independently working on it, I just need to figure out kconfig but it is so boring as I do not use the kconfig menu, as I always just changed the source code — Reply to this email directly, view it on GitHub <#73 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACH63BB5XZBZCG2OSND7BDY4O6E7AVCNFSM6AAAAABCFC2OXSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBUGY2TGNZXGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[guiodic]

@nicman23 do you have any news? Is it possible to test the decoration?

[nicman23]

sorry guys it is a tough month, i might just upload whatever i have already done but yeah i have not worked at it at all

[guiodic]

Thank you very much! I dont care kconfig for now, default options are ok for me, I will eventually change source code. Or, if present, the values in kwinrc.

[guiodic]

@nicman23 sorry to bother you but... any news?

[nicman23]

sorry here is the wip code https://github.com/nicman23/material-decoration but still no progress since my first message

[guiodic]

thank you. I tried to build it. I receive an error on qtdbusmenu so I tried commenting the line in cmake but then I receive another error on "FindQt.cmake".
Well, I will wait...

[Anarcraft]

On my test machine I don't see a package named "Qt6" which this would parse to:
find_package(QT NAMES Qt${QT_VERSION_MAJOR})
It may be the package named "Qt6-base".

[guiodic]

On my test machine I don't see a package named "Qt6" which this would parse to: find_package(QT NAMES Qt${QT_VERSION_MAJOR}) It may be the package named "Qt6-base".

I presume "package" in cmake refers to QT internal names, not to the packages from the distribution.

[Anarcraft]

On my test machine I don't see a package named "Qt6" which this would parse to: find_package(QT NAMES Qt${QT_VERSION_MAJOR}) It may be the package named "Qt6-base".

I presume "package" in cmake refers to QT internal names, not to the packages from the distribution.

Oh, OK, I don't know much about cmake.

[guiodic]

@nicman23 sorry to bother you again ...

[nicman23]

i ll take a crack at it if i have no work today

[nicman23]

i did make it compile but it does not show up in system config. if at all possible @Zren could you take a look?

it is not buy any way ready - i have removed the configuration for now - but it should had worked (?)

just for reference it compiles with qt6 and kf6

[guiodic]

thank you. I still receive this error:

CMake Error at /usr/lib/cmake/Qt6DBus/Qt6DBusMacros.cmake:64 (qt5_add_dbus_interface):
Unknown CMake command "qt5_add_dbus_interface".
Call Stack (most recent call first):
src/libdbusmenuqt/CMakeLists.txt:24 (qt_add_dbus_interface)

[guiodic]

and if I comment the qt dbusmenu including in cmake, thei I receive this other error:
CMake Error at /usr/lib/cmake/Qt6Qml/Qt6QmlMacros.cmake:2829 (message):
qt_generate_foreign_qml_types() is only available in Qt 6.
Call Stack (most recent call first):
/usr/lib/cmake/Qt6Qml/Qt6QmlConfig.cmake:145 (include)
/usr/share/cmake/Modules/CMakeFindDependencyMacro.cmake:76 (find_package)
/usr/lib/cmake/KF6Config/KF6ConfigConfig.cmake:53 (find_dependency)
/usr/share/ECM/find-modules/FindKF6.cmake:52 (find_package)
src/CMakeLists.txt:13 (find_package)

(I'm on Manjaro unstable, it's pretty the same of arch)

[guiodic]

p.s. I use this command to build:
cmake -DCMAKE_INSTALL_PREFIX=/usr ..

[nicman23]

try cmake -DQT_MAJOR_VERSION=6 -DCMAKE_INSTALL_PREFIX=/usr ..

[guiodic]

yes, it works! thank you! but it has not shadow

[guiodic]

i tried to add this to kdecoration_materialrc

[Common]
MenuAlwaysShow=true
ShadowStrength=128

but the shadow doesn't show. Anyway the menu works

[nicman23]

what? tf, it does not work on my machine :D

E: huh the .so is installed in the wrong folder. i do not care to look into it right now, i just did a

cp src/materialdecoration.so /usr/lib/qt6/plugins/org.kde.kdecoration2/

and it worked lol

[guiodic]

@nicman23 I hope the shadows can be restored.

[nicman23]

i do not use them so probably eh maybe

[guiodic]

i do not use them so probably eh maybe

Please 🙏🙏🙏

[guiodic]

@nicman23 can you at least make some suggestions? I tried fiddling with the code but couldn't solve the shadow problem. Thank you!

@Zren some love for this bug? Thanks!

[guiodic]

Sorry again @nicman23 ...

[guiodic]

To restore shadows, in the Decoration.cc, line 567

if (!s_cachedShadow ---> if (s_cachedShadow

[guiodic]

Is there any chance of this decoration being ported to Wayland?

[nicman23]

no

[guiodic]

no

maybe @Zren ?

[nicman23]

no i mean it is currently not possible

[guiodic]

no i mean it is currently not possible

Can you explain why? Thank you!

[HerrCraziDev]

no i mean it is currently not possible

Can you explain why? Thank you!

Because Wayland sucks. It's much more restrictive than X11.

Also, any progress on this ?

[guiodic]

no i mean it is currently not possible

Can you explain why? Thank you!

Because Wayland sucks. It's much more restrictive than X11.

Also, any progress on this ?

I agree on Wayland sucks etc. but in this particular case I think there are no major problems, in fact the global menu and the menu button in the title bar work correctly (at least for QT apps, the GTK ones have a problem upstream)

[HerrCraziDev]

Damn I'll have to switch to Debian /s

[guiodic]

@nicman23 hi, can you help me to solve the bug with libreoffice? #65

[HerrCraziDev]

I guess this is dead :'(

[guiodic]

@HerrCraziDev

Hi, @nicman23 updated this to Plasma 6 and I made some little adjustment (restore shadows, remove deprecated functions). You can find it in my github: https://github.com/guiodic/material-decoration

I am trying to understand the problem. Perhaps it is related to the fact that the _KDE_NET_WM_APPMENU_OBJECT_PATH property changes.

In fact, if the gtk3 plugin of Libreoffice is used, the property in question does not change and the menu works correctly, updating.

[HerrCraziDev]

Ooh, awesome 😎 I will try it out asap tonight!

[guiodic]

@HerrCraziDev If you have Arch or derivatives there is already a package
https://aur.archlinux.org/packages/material-kwin-decoration-git

[nicman23]

hey, nice! @guiodic, libreoffice and gtk apps in general never worked quite right with appmenu in general not just with the appmenu that the decoration uses. did you try libreoffice-qt?

[guiodic]

hey, nice! @guiodic, libreoffice and gtk apps in general never worked quite right with appmenu in general not just with the appmenu that the decoration uses. did you try libreoffice-qt?

The problem is precisely with Libreoffice-qt. With gtk3 works just fine.
Perhaps it is related to the fact that the _KDE_NET_WM_APPMENU_OBJECT_PATH property changes.
This happens with QT (both 5 and 6, but also kf5 and kf6) whereas with gtk3 the property remains the same.

[guiodic]

@nicman23 To give an example, open libreoffice starcenter (using qt5 or qt6), the menu appears. But if you start Writer from there, the menu either disappears (qt5) or the starcenter menu remains (qt6).

Using xprop I found that when you open Writer the _KDE_NET_WM_APPMENU_OBJECT_PATH property changes. Perhaps that is the problem.

[nicman23]

uh i remember i had issues with one of the versions but i guess i had them mixed up. to be honest, i really do not have time these weeks but i ll try to see what is up soon (tm)

[guiodic]

uh i remember i had issues with one of the versions but i guess i had them mixed up. to be honest, i really do not have time these weeks but i ll try to see what is up soon (tm)

sorry to bother you... any news?

[guiodic]

I obtained the result in this way:

void AppMenuModel::onX11WindowChanged(WId id)
{
    qApp->removeNativeEventFilter(this);
    if (m_winId.toUInt() == id) {
        qApp->installNativeEventFilter(this);
        m_delayedMenuWindowId = id;
    }
}

However, it does not seem efficient to me because it is called up every time the window changes (so even if I move it, it shrinks) and it also seems prone to memory leakage

@nicman23 do you have any suggestions?

[guiodic]

Hi @nicman23

I modified lines 139-141 like this:

void (KX11Extras::*myWindowChangeSignal)(WId window, NET::Properties properties, NET::Properties2 properties2) = &KX11Extras::windowChanged;
connect(KX11Extras::self(), myWindowChangeSignal,
        this, [this](WId window, NET::Properties properties, NET::Properties2 properties2) {
            if (properties2 & NET::WM2AppMenuObjectPath) {
                qCDebug(category) << "WM2AppMenuObjectPath changed";
                QTimer::singleShot(50, this, &AppMenuModel::onWinIdChanged);
           }

But I see that the signal is triggered repeatedly (4-6 times) every time I open a window, which is why I put the QTimer, but it doesn't seem like an optimal solution. Do you have any idea why this happens? Please help me! Thanks!

[guiodic]

@nicman23 I think I found a workaround, I accidentally turned it into a pull request on your repository, I actually wanted to make a pull request on my own.

Anyway if you can take a look at it and tell me what you think thanks!

nicman23#2

[nicman23]

sorry guys I went with plasma 5 and almalinux. see you at 2032