New Xebec S1410 vendor command and various work #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jernej Jakob <[email protected]>
…ics" Signed-off-by: Jernej Jakob <[email protected]>
Other callback functions do it, it also makes sense to do it here. Signed-off-by: Jernej Jakob <[email protected]>
Signed-off-by: Jernej Jakob <[email protected]>
Handle all sense codes that the current code can produce. Xebec has more possible sense codes but they currently aren't needed. Since there is no direct mapping from SCSI sense data to the Xebec proprietary sense data, the codes were matched as closely as possible. Signed-off-by: Jernej Jakob <[email protected]>
|
Looks reasonable to me. SCSI2SD development is somewhat stalled lately (lack of hardware availability), so it's typically easier just to modify our own fork. |
|
Thanks for your contribution, @jjakob We appreciate it! Merged :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should I send the SCSI2SD changes to upstream first?
Edit: I sent the four SCSI2SD-V6 patches to Michael McMaster [email protected] so he can hopefully merge them.