Log Xebec vendor command and decoded data #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jernej Jakob <[email protected]>
|
I think this is the best place, it keeps all the non-essential trace logging in one place, even if it needs a bit funny if-conditions to do so. Because this is using To me this looks ready to merge. |
|
I tested it on hardware and couldn't see any issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is the best place to put this. The only other possibly better place is in SCSI2SD in the DATA_OUT callback function, but that is part of the library and so can't access the log functions. I'm also not sure if I need to add a check somewhere if debug logging is enabled.