draw referenced ways and nodes for selected relations #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay, this looks good, though I'm not sure this is useful. Thanks. |
Zverik
added a commit
that referenced
this pull request
Jan 26, 2016
draw referenced ways and nodes for selected relations
Why not? |
|
Relations are usually obvious from their tags (e.g. routes), and if not, showing their members would be more useful, since the focus of this editor is on individual objects. |
|
So, why did you propose it in #15 (comment), then? 😕 |
|
I proposed to draw single referenced members of relations. |
|
Aaah, I see. That would make sense as well. For example, the selected member could be drawn in a separate "highlight" colour. I'll see what I can do… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements functionality for #15
Way-member drawing is implemented as a recursive call to
text2coordwhich would technically even allow to draw nested relations (but I wasn't sure if that makes much sense in practice and one would have to make sure that reference-loops are handled properly, which can be hairy!).