Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add style expression support #1058

Merged
merged 7 commits into from
Jan 30, 2025
Merged

feat: add style expression support #1058

merged 7 commits into from
Jan 30, 2025

Conversation

a-h
Copy link
Owner

@a-h a-h commented Jan 29, 2025

No description provided.

@a-h a-h requested a review from joerdav January 29, 2025 07:29
joerdav
joerdav reviewed Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@joerdav joerdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few things I spotted, but nothing major. The bulk of it all looks good to me.

docs/docs/03-syntax-and-usage/11-css-style-management.md Outdated Show resolved Hide resolved
docs/docs/03-syntax-and-usage/11-css-style-management.md Outdated Show resolved Hide resolved
generator/generator.go Outdated Show resolved Hide resolved
generator/generator.go Outdated Show resolved Hide resolved
generator/generator.go Outdated Show resolved Hide resolved
generator/generator.go Outdated Show resolved Hide resolved
runtime/styleattribute.go Outdated Show resolved Hide resolved
runtime/styleattribute.go Outdated Show resolved Hide resolved
@a-h a-h merged commit fea7372 into main Jan 30, 2025
7 checks passed
@a-h a-h deleted the add_style_expression_support branch January 30, 2025 18:16
@phenpessoa
Copy link
Contributor

This is huge, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joerdav joerdav joerdav left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a-h @phenpessoa @joerdav