Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DeepSpeed fixes #7

Merged
merged 1 commit into from
Oct 8, 2024
Merged

DeepSpeed fixes #7

merged 1 commit into from
Oct 8, 2024

Conversation

a-r-r-o-w
Copy link
Owner

Based on this comment

@a-r-r-o-w a-r-r-o-w requested a review from sayakpaul October 8, 2024 10:23
sayakpaul
sayakpaul approved these changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's it?

Could you also include some instructions to enable DeepSpeed Zero2 then? Can be done in a follow-up PR too.

@a-r-r-o-w
Copy link
Owner Author

The scripts already supported DeepSpeed from the beginning but there was a bug in the lr scheduler part, which has now been fixed I believe. For enabling DeepSpeed, we just need to configure with accelerate correctly (I'll push configs of those in a follow-up PR)

@a-r-r-o-w a-r-r-o-w merged commit 0937e92 into main Oct 8, 2024
@a-r-r-o-w a-r-r-o-w deleted the deepspeed-fixes branch October 8, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayakpaul sayakpaul sayakpaul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a-r-r-o-w @sayakpaul