Improve field order #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
============================================
- Coverage 68.46% 66.11% -2.35%
+ Complexity 41 39 -2
============================================
Files 7 6 -1
Lines 130 121 -9
============================================
- Hits 89 80 -9
Misses 41 41
Continue to review full report at Codecov.
|
|
Do you have time for a review @webda2l ? Thank you for your time :) |
|
Sound good, thanks @jordisala1991 ! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to address the issue with the fields order for auto Form.
The problem (related to #11) is because by default the orm field order is not related to the class property order or the table field order, so relying on it is not recommended in any way. You can see:
https://stackoverflow.com/questions/24148568/doctrineschemaupdate-doesnt-respect-column-order
With this changes, the code is simpler, the test suite passes and also we are now relying on the order of the fields provided, without any extra configuration.
Closes #11