Skip to content
This repository has been archived by the owner on Dec 28, 2022. It is now read-only.

Fix/dependency vulnerability #22

Merged

Conversation

Isabelar07
Copy link

fixes vulnerability of dependencies

@Isabelar07 Isabelar07 changed the base branch from main to develop September 25, 2021 03:50
@vcwild
Copy link
Member

vcwild commented Sep 25, 2021

Resolves #21

Copy link

@DevRadhy DevRadhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link

@RodrigoDornelles RodrigoDornelles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eu não manjo tanto do eco sistema de javascript, mas apareceu alguns alertas de dependências ultrapassadas, consegue aferir o impacto e talvez corrigir?

npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
npm WARN deprecated [email protected]: The querystring API is considered Legacy. new code should use the URLSearchParams API instead.
npm WARN deprecated [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated [email protected]: some dependency vulnerabilities fixed, support for node < 10 dropped, and newer ECMAScript syntax/features added
npm WARN deprecated @types/[email protected]: Mongoose publishes its own types, so you do not need to install this package.

@Isabelar07
Copy link
Author

não estamos usando uuid, usamos o object_id do mongo. Não sei se object_id usa o uuid por debaixo dos panos, mas acredito que isso não vai impactar na api, assim como os demais. Mas posso "atualizar" se for o caso. Em relação ao type do mongoose, vou deixar com ele mesmo. O emídio tem mais experiência com mongo e nestjs do que eu, então acredito que ele colocou o type por algum motivo.

Copy link

@RodrigoDornelles RodrigoDornelles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aprovado então! deixo para o @caio-emidio considerar essas coisas futuramente!

@Isabelar07 Isabelar07 merged commit d0a0aad into aHub-Tech:develop Sep 29, 2021
@caio-emidio
Copy link
Contributor

Um esquema ali era ter dado upgrade e ver se vai dar B.O.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problema com dependências do projeto unable to resolve dependency tree
5 participants