Add -fanalyzer to make debug

aaaaaa123456789 · Jan 15, 2022 · 2860ce3 · 2860ce3
1 parent c39ba51
commit 2860ce3
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 11 deletions.
diff --git a/Makefile b/Makefile
@@ -7,7 +7,7 @@ CFLAGS = -Ofast -fomit-frame-pointer -fno-asynchronous-unwind-tables -fno-except
 
 DEBUGFLAGS = -Wall -Wextra -pedantic -Wcast-align -Wduplicated-branches -Wduplicated-cond -Wlogical-op \
              -Wnull-dereference -Wshadow -Wshift-overflow=2 -Wundef -Wunused -Wwrite-strings -Wno-sign-compare \
-             -Wno-implicit-fallthrough -Wno-parentheses -Wno-dangling-else
+             -Wno-implicit-fallthrough -Wno-parentheses -Wno-dangling-else -fanalyzer -fanalyzer-verbosity=0
 
 .PHONY: all clean basefiles debug
 

diff --git a/src/jpeghierarchical.c b/src/jpeghierarchical.c
@@ -36,17 +36,18 @@ unsigned load_hierarchical_JPEG (struct context * context, const struct JPEG_mar
         double * data = output[frameIDs[p]];
         for (index = 0; index < limit; index ++) data[index] = (uint16_t) ((long) (data[index] + 65536.5)); // avoid UB and round negative values correctly
       }
-      double * buffer = NULL;
-      if (expand) buffer = ctxmalloc(context, sizeof *buffer * framewidth * frameheight);
-      if (expand & 0x10) for (p = 0; p < framecount; p ++) {
-        expand_JPEG_component_horizontally(context, output[frameIDs[p]], component_size[frameIDs[p]], component_size[frameIDs[p] + 4], framewidth, buffer);
-        component_size[frameIDs[p]] = framewidth;
-      }
-      if (expand & 1) for (p = 0; p < framecount; p ++) {
-        expand_JPEG_component_vertically(context, output[frameIDs[p]], component_size[frameIDs[p]], component_size[frameIDs[p] + 4], frameheight, buffer);
-        component_size[frameIDs[p] + 4] = frameheight;
+      if (expand) {
+        double * buffer = ctxmalloc(context, sizeof *buffer * framewidth * frameheight);
+        if (expand & 0x10) for (p = 0; p < framecount; p ++) {
+          expand_JPEG_component_horizontally(context, output[frameIDs[p]], component_size[frameIDs[p]], component_size[frameIDs[p] + 4], framewidth, buffer);
+          component_size[frameIDs[p]] = framewidth;
+        }
+        if (expand & 1) for (p = 0; p < framecount; p ++) {
+          expand_JPEG_component_vertically(context, output[frameIDs[p]], component_size[frameIDs[p]], component_size[frameIDs[p] + 4], frameheight, buffer);
+          component_size[frameIDs[p] + 4] = frameheight;
+        }
+        ctxfree(context, buffer);
       }
-      ctxfree(context, buffer);
       for (p = 0; p < framecount; p ++) if ((component_size[frameIDs[p]] != framewidth) || (component_size[frameIDs[p] + 4] != frameheight))
         throw(context, PLUM_ERR_INVALID_FILE_FORMAT);
     } else {