Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setting device to lanzcos_low_rank_hessian_approx #393

Merged
merged 7 commits into from
Aug 18, 2023
Merged

setting device to lanzcos_low_rank_hessian_approx #393

merged 7 commits into from
Aug 18, 2023

Conversation

Xuzzo
Copy link
Collaborator

@Xuzzo Xuzzo commented Aug 7, 2023

Description

This PR closes #391

Changes

  • adds a warning for low rank approximation when device is gpu
  • re allocates eigenvals and eigenvecs to gpu before returning in lanzcos_low_rank_hessian_approx

Checklist

  • Wrote Unit tests (if necessary)
  • Updated Documentation (if necessary)
  • Updated Changelog
  • If notebooks were added/changed, added boilerplate cells are tagged with "nbsphinx":"hidden"

@Xuzzo Xuzzo requested review from schroedk and murong-xu August 7, 2023 13:32
@Xuzzo Xuzzo self-assigned this Aug 7, 2023
@Xuzzo Xuzzo added the bug Something isn't working label Aug 7, 2023
schroedk
schroedk reviewed Aug 7, 2023
View reviewed changes
Copy link
Collaborator

@schroedk schroedk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Xuzzo I will test the changes via running tests on GPU

@schroedk
Move exception raise to solve_arnoldi level:
c538965 
* raise exception messages with info how to resolve
* add functionality to LowRankRepresentation
* provide function to precompute low rank approximations
@schroedk
Copy link
Collaborator

@Xuzzo Most probably, there will be conflicts with #394 . I will resolve them, depending on which branch is merged first.

@Xuzzo Xuzzo merged commit 534b28c into develop Aug 18, 2023
@schroedk schroedk deleted the fix/device_in_arnoldi branch August 23, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schroedk schroedk schroedk approved these changes

@murong-xu murong-xu Awaiting requested review from murong-xu

Assignees

@Xuzzo Xuzzo

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Device error in solve_arnoldi()
2 participants
@Xuzzo @schroedk