-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs and cleanup #492
Docs and cleanup #492
Conversation
…nstead of neoteroi-mkdocs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. I left a couple of comments and additions. Do you plan to take care of the other forgotten deprecations, or leave that for another PR?
Co-authored-by: Miguel de Benito Delgado <[email protected]>
I took care of the simple ones only in order to be able to finish this PR for the next release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small fix and also we should probably delete the subsection on applications within the introduction, or merge it with applications.md
in case it adds something.
Co-authored-by: Miguel de Benito Delgado <[email protected]>
I merged the two sections into one and then decided to remove more deprecated code and updated the tests accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
Description
This PR closes address parts of #462 and #489.
Changes
first-steps.md
from Getting Started to First Steps to match the filename.memcached
extra in all tox test environments (some notebooks were failing because of this).Checklist
Wrote Unit tests (if necessary)If notebooks were added/changed, added boilerplate cells are tagged with"tags": ["hide"]
or"tags": ["hide-input"]