-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminate subtyping around type signal #59
Comments
I am considering doing this and re-releasing it as part of a retagged 1.0.0. Sorry about the churn. I realize you just updated your deps to allow Markup 1.0.0, and now this comes up :P See #58 (comment) for the current motivation behind doing this. I also had similar issues during the original development of Markup, but I managed to massage all the types in the original release to fit. |
This change is done to accomodate aantron/markup.ml#59.
Okay, I just opened a PR on ocaml/opam-repository to downgrade markup back to below 1.0.0. |
Done to accommodate aantron/markup.ml#59.
Several functions in Markup.ml accept narrower types than
signal
. For example,markup.ml/src/markup.mli
Line 710 in b4b59ae
These functions are difficult to modify freely, for example as in #58.
The only function in Markup.ml that produces a stream with a narrower type than
signal
iscontent
:markup.ml/src/markup.mli
Lines 548 to 550 in b4b59ae
If this were just
(signal, 's) stream -> (signal, 's) stream
, it would force users only to add a wildcard case to any pattern matching they do on the signals. Conversely, the benefit would be a library interface that is shorter, easier to understand, and an implementation that is much easier to edit.The text was updated successfully, but these errors were encountered: